Commit 96882e1
src: fix handle leak in Buffer::New()
Fix handle leaks in Buffer::New() and Buffer::Copy() by creating the
handle scope before looking up the env with Environment::GetCurrent().
Environment::GetCurrent() calls v8::Isolate::GetCurrentContext(), which
creates a handle in the current scope, i.e., the scope created by the
caller of Buffer::New() or Buffer::Copy().
PR-URL: #7711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>1 parent 9847f84 commit 96882e1
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -320,8 +320,8 @@ MaybeLocal<Object> New(Environment* env, size_t length) { | |||
| 320 | 320 | ||
| 321 | 321 | ||
| 322 | 322 | MaybeLocal<Object> Copy(Isolate* isolate, const char* data, size_t length) { | |
| 323 | + EscapableHandleScope handle_scope(isolate); | ||
| 323 | 324 | Environment* env = Environment::GetCurrent(isolate); | |
| 324 | - EscapableHandleScope handle_scope(env->isolate()); | ||
| 325 | 325 | Local<Object> obj; | |
| 326 | 326 | if (Buffer::Copy(env, data, length).ToLocal(&obj)) | |
| 327 | 327 | return handle_scope.Escape(obj); | |
@@ -370,8 +370,8 @@ MaybeLocal<Object> New(Isolate* isolate, | |||
| 370 | 370 | size_t length, | |
| 371 | 371 | FreeCallback callback, | |
| 372 | 372 | void* hint) { | |
| 373 | + EscapableHandleScope handle_scope(isolate); | ||
| 373 | 374 | Environment* env = Environment::GetCurrent(isolate); | |
| 374 | - EscapableHandleScope handle_scope(env->isolate()); | ||
| 375 | 375 | Local<Object> obj; | |
| 376 | 376 | if (Buffer::New(env, data, length, callback, hint).ToLocal(&obj)) | |
| 377 | 377 | return handle_scope.Escape(obj); | |
@@ -409,8 +409,8 @@ MaybeLocal<Object> New(Environment* env, | |||
| 409 | 409 | ||
| 410 | 410 | ||
| 411 | 411 | MaybeLocal<Object> New(Isolate* isolate, char* data, size_t length) { | |
| 412 | + EscapableHandleScope handle_scope(isolate); | ||
| 412 | 413 | Environment* env = Environment::GetCurrent(isolate); | |
| 413 | - EscapableHandleScope handle_scope(env->isolate()); | ||
| 414 | 414 | Local<Object> obj; | |
| 415 | 415 | if (Buffer::New(env, data, length).ToLocal(&obj)) | |
| 416 | 416 | return handle_scope.Escape(obj); | |
0 commit comments