Commit 9730482
test: remove the legacy url parser function
PR-URL: #42656
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0ef18fe commit 9730482
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,8 +5,7 @@ const fs = require('fs'); | |||
| 5 | 5 | const http = require('http'); | |
| 6 | 6 | const fixtures = require('../common/fixtures'); | |
| 7 | 7 | const { spawn } = require('child_process'); | |
| 8 | - const { parse: parseURL } = require('url'); | ||
| 9 | - const { pathToFileURL } = require('url'); | ||
| 8 | + const { URL, pathToFileURL } = require('url'); | ||
| 10 | 9 | const { EventEmitter } = require('events'); | |
| 11 | 10 | ||
| 12 | 11 | const _MAINSCRIPT = fixtures.path('loop.js'); | |
@@ -417,7 +416,8 @@ class NodeInstance extends EventEmitter { | |||
| 417 | 416 | const port = await this.portPromise; | |
| 418 | 417 | return http.get({ | |
| 419 | 418 | port, | |
| 420 | - path: parseURL(devtoolsUrl).path, | ||
| 419 | + family: 4, | ||
| 420 | + path: new URL(devtoolsUrl).pathname, | ||
| 421 | 421 | headers: { | |
| 422 | 422 | 'Connection': 'Upgrade', | |
| 423 | 423 | 'Upgrade': 'websocket', | |
0 commit comments