Commit 97470b1
tools: do not pass invalid flag to C compiler
`-Wno-invalid-offsetof` is only valid for C++ and GCC warns about its
usage for C.
PR-URL: #51409
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent bff7e3c commit 97470b1
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1970,6 +1970,12 @@ | |||
| 1970 | 1970 | ] | |
| 1971 | 1971 | }], | |
| 1972 | 1972 | ], | |
| 1973 | + # -Wno-invalid-offsetof flag is not valid for C. | ||
| 1974 | + # The flag is initially set in `toolchain.gypi` for all targets. | ||
| 1975 | + 'cflags!': [ '-Wno-invalid-offsetof' ], | ||
| 1976 | + 'xcode_settings': { | ||
| 1977 | + 'WARNING_CFLAGS!': ['-Wno-invalid-offsetof'] | ||
| 1978 | + }, | ||
| 1973 | 1979 | 'direct_dependent_settings': { | |
| 1974 | 1980 | 'include_dirs': [ | |
| 1975 | 1981 | '<(V8_ROOT)/third_party/zlib', | |
0 commit comments