Commit 9747735
deps: V8: cherry-pick 4f38995c8295
Original commit message:
[explicit-resource-management] Turn flag on by default
This feature has shipped since M134 on the blink side, and is highly
unlikely to be unshipped now, so flip the flag on.
Bug: 42203506
Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100069}
Refs: v8/v8@4f38995
PR-URL: #58230
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #58064
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent 70bfc39 commit 9747735
3 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.10', | ||
| 41 | + 'v8_embedder_string': '-node.11', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -295,7 +295,6 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features") | |||
| 295 | 295 | // Features that are complete (but still behind the --harmony flag). | |
| 296 | 296 | #define HARMONY_STAGED_BASE(V) | |
| 297 | 297 | #define JAVASCRIPT_STAGED_FEATURES_BASE(V) \ | |
| 298 | - V(js_explicit_resource_management, "explicit resource management") \ | ||
| 299 | 298 | V(js_float16array, \ | |
| 300 | 299 | "Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16") | |
| 301 | 300 | ||
@@ -311,7 +310,7 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features") | |||
| 311 | 310 | #endif | |
| 312 | 311 | ||
| 313 | 312 | // Features that are shipping (turned on by default, but internal flag remains). | |
| 314 | - #define HARMONY_SHIPPING_BASE(V) \ | ||
| 313 | + #define HARMONY_SHIPPING_BASE(V) \ | ||
| 315 | 314 | V(harmony_import_attributes, "harmony import attributes") | |
| 316 | 315 | ||
| 317 | 316 | #define JAVASCRIPT_SHIPPING_FEATURES_BASE(V) \ | |
@@ -320,7 +319,8 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features") | |||
| 320 | 319 | V(js_promise_try, "Promise.try") \ | |
| 321 | 320 | V(js_atomics_pause, "Atomics.pause") \ | |
| 322 | 321 | V(js_error_iserror, "Error.isError") \ | |
| 323 | - V(js_regexp_escape, "RegExp.escape") | ||
| 322 | + V(js_regexp_escape, "RegExp.escape") \ | ||
| 323 | + V(js_explicit_resource_management, "explicit resource management") | ||
| 324 | 324 | ||
| 325 | 325 | #ifdef V8_INTL_SUPPORT | |
| 326 | 326 | #define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,7 +9,7 @@ var iteratorPrototype = arrayIteratorPrototype.__proto__; | |||
| 9 | 9 | assertSame(Object.prototype, Object.getPrototypeOf(iteratorPrototype)); | |
| 10 | 10 | assertTrue(Object.isExtensible(iteratorPrototype)); | |
| 11 | 11 | assertSame(12, Object.getOwnPropertyNames(iteratorPrototype).length); | |
| 12 | - assertSame(2, Object.getOwnPropertySymbols(iteratorPrototype).length); | ||
| 12 | + assertSame(3, Object.getOwnPropertySymbols(iteratorPrototype).length); | ||
| 13 | 13 | assertSame(Symbol.iterator, | |
| 14 | 14 | Object.getOwnPropertySymbols(iteratorPrototype)[0]); | |
| 15 | 15 | ||
0 commit comments