Commit 976827c
committed
tools: validate version number in release proposal commit message lint
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64070
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>1 parent 8a5d3bc commit 976827c
1 file changed
Lines changed: 16 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -28,13 +28,24 @@ jobs: | |||
| 28 | 28 | persist-credentials: false | |
| 29 | 29 | fetch-depth: 2 | |
| 30 | 30 | - name: Lint release commit title format | |
| 31 | + id: commit-message-parse | ||
| 31 | 32 | run: | | |
| 32 | - EXPECTED_TITLE='^[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2}, Version [[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+ (\(Current|'.+' \(LTS)\)$' | ||
| 33 | + VERSION=$(${CXX:-cc} -E -dM src/node_version.h | awk ' | ||
| 34 | + $2 == "NODE_MAJOR_VERSION" { maj = $3 } | ||
| 35 | + $2 == "NODE_MINOR_VERSION" { min = $3 } | ||
| 36 | + $2 == "NODE_PATCH_VERSION" { pat = $3 } | ||
| 37 | + $2 == "NODE_VERSION_LTS_CODENAME" { gsub(/^"|"$/, "'"'"'",$3); lts = $3 } | ||
| 38 | + END { if (maj) print maj "\\." min "\\." pat " " (lts != "'"''"'" ? lts " \\(LTS" : "\\(Current" ) "\\)" } | ||
| 39 | + ') | ||
| 40 | + MAJOR=${VERSION%%\\.*} | ||
| 41 | + EXPECTED_TITLE='^[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2}, Version '"$VERSION"'$' | ||
| 33 | 42 | echo "Expected commit title format: $EXPECTED_TITLE" | |
| 34 | 43 | COMMIT_SUBJECT="$(git --no-pager log -1 --format=%s)" | |
| 35 | - echo "Actual: $ACTUAL" | ||
| 44 | + echo "Actual: $COMMIT_SUBJECT" | ||
| 36 | 45 | echo "$COMMIT_SUBJECT" | grep -q -E "$EXPECTED_TITLE" | |
| 37 | - echo "COMMIT_SUBJECT=$COMMIT_SUBJECT" >> "$GITHUB_ENV" | ||
| 46 | + | ||
| 47 | + echo "COMMIT_SUBJECT=$COMMIT_SUBJECT" >> "$GITHUB_OUTPUT" | ||
| 48 | + echo "MAJOR=$MAJOR" >> "$GITHUB_OUTPUT" | ||
| 38 | 49 | - name: Lint release commit message trailers | |
| 39 | 50 | run: | | |
| 40 | 51 | EXPECTED_TRAILER="^$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/pull/[[:digit:]]+\$" | |
@@ -54,8 +65,6 @@ jobs: | |||
| 54 | 65 | SKIP_XZ=1 make release-only | |
| 55 | 66 | - name: Lint release commit content | |
| 56 | 67 | run: | | |
| 57 | - MAJOR="$(awk '/^#define NODE_MAJOR_VERSION / { print $3 }' src/node_version.h)" | ||
| 58 | - | ||
| 59 | 68 | echo "Checking for expected files in the release commit:" | |
| 60 | 69 | missing_expected= | |
| 61 | 70 | for expected in CHANGELOG.md src/node_version.h doc/changelogs/; do | |
@@ -81,7 +90,6 @@ jobs: | |||
| 81 | 90 | run: | | |
| 82 | 91 | EXPECTED_CHANGELOG_TITLE_INTRO="## $COMMIT_SUBJECT, @" | |
| 83 | 92 | echo "Expected CHANGELOG section title: $EXPECTED_CHANGELOG_TITLE_INTRO" | |
| 84 | - MAJOR="$(awk '/^#define NODE_MAJOR_VERSION / { print $3 }' src/node_version.h)" | ||
| 85 | 93 | CHANGELOG_PATH="doc/changelogs/CHANGELOG_V${MAJOR}.md" | |
| 86 | 94 | CHANGELOG_TITLE="$(grep "$EXPECTED_CHANGELOG_TITLE_INTRO" "$CHANGELOG_PATH")" | |
| 87 | 95 | echo "Actual: $CHANGELOG_TITLE" | |
@@ -106,4 +114,6 @@ jobs: | |||
| 106 | 114 | done | |
| 107 | 115 | shell: bash # See https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference, we want the pipefail option. | |
| 108 | 116 | env: | |
| 117 | + COMMIT_SUBJECT: ${{ steps.commit-message-parse.outputs.COMMIT_SUBJECT }} | ||
| 118 | + MAJOR: ${{ steps.commit-message-parse.outputs.MAJOR }} | ||
| 109 | 119 | GH_TOKEN: ${{ github.token }} | |
0 commit comments