FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: reduce flakiness of test-runner-output.mjs · nodejs/node@978d5a2 · GitHub

/ node Public

Commit 978d5a2

Browse files
cjihrig
authored
test: reduce flakiness of test-runner-output.mjs
This commit is similar to #51952. When the system is under load it is possible for these timeout tests to become flaky. We work around that by using a much longer setTimeout() in the test so that it is not racing against the test's timeout. But, we have to unref() such a large timeout. And, because test timeouts do not currently keep the event loop alive, we use a different setTimeout() for that purpose. Fixes: #52139 Refs: #52140 PR-URL: #52146 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent be75821 commit 978d5a2

2 files changed

Lines changed: 64 additions & 46 deletions

File tree

‎test/fixtures/test-runner/output/lcov_reporter.snapshot‎

Lines changed: 56 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -81,24 +81,26 @@ FN:310,anonymous_77
8181
FN:313,anonymous_78
8282
FN:318,anonymous_79
8383
FN:319,anonymous_80
84-
FN:324,anonymous_81
85-
FN:329,anonymous_82
86-
FN:330,anonymous_83
84+
FN:320,anonymous_81
85+
FN:327,anonymous_82
86+
FN:328,anonymous_83
8787
FN:335,anonymous_84
88-
FN:339,anonymous_85
89-
FN:342,get then
88+
FN:336,anonymous_85
89+
FN:341,anonymous_86
9090
FN:345,anonymous_87
91-
FN:350,anonymous_88
92-
FN:353,get then
91+
FN:348,get then
92+
FN:351,anonymous_89
9393
FN:356,anonymous_90
94-
FN:361,anonymous_91
94+
FN:359,get then
9595
FN:362,anonymous_92
96-
FN:363,anonymous_93
97-
FN:367,anonymous_94
98-
FN:368,anonymous_95
99-
FN:369,anonymous_96
100-
FN:375,anonymous_97
101-
FN:379,anonymous_98
96+
FN:367,anonymous_93
97+
FN:368,anonymous_94
98+
FN:369,anonymous_95
99+
FN:373,anonymous_96
100+
FN:374,anonymous_97
101+
FN:375,anonymous_98
102+
FN:381,anonymous_99
103+
FN:385,anonymous_100
102104
FNDA:1,anonymous_0
103105
FNDA:1,anonymous_1
104106
FNDA:1,anonymous_2
@@ -185,21 +187,23 @@ FNDA:1,anonymous_82
185187
FNDA:1,anonymous_83
186188
FNDA:1,anonymous_84
187189
FNDA:1,anonymous_85
188-
FNDA:1,get then
190+
FNDA:1,anonymous_86
189191
FNDA:1,anonymous_87
190-
FNDA:1,anonymous_88
191192
FNDA:1,get then
193+
FNDA:1,anonymous_89
192194
FNDA:1,anonymous_90
193-
FNDA:1,anonymous_91
195+
FNDA:1,get then
194196
FNDA:1,anonymous_92
195197
FNDA:1,anonymous_93
196198
FNDA:1,anonymous_94
197199
FNDA:1,anonymous_95
198200
FNDA:1,anonymous_96
199201
FNDA:1,anonymous_97
200202
FNDA:1,anonymous_98
201-
FNF:99
202-
FNH:96
203+
FNDA:1,anonymous_99
204+
FNDA:1,anonymous_100
205+
FNF:101
206+
FNH:98
203207
BRDA:1,0,0,1
204208
BRDA:8,1,0,1
205209
BRDA:12,2,0,1
@@ -279,30 +283,32 @@ BRDA:310,75,0,1
279283
BRDA:313,76,0,1
280284
BRDA:318,77,0,1
281285
BRDA:319,78,0,1
282-
BRDA:324,79,0,1
283-
BRDA:329,80,0,1
284-
BRDA:330,81,0,1
286+
BRDA:320,79,0,1
287+
BRDA:327,80,0,1
288+
BRDA:328,81,0,1
285289
BRDA:335,82,0,1
286-
BRDA:339,83,0,1
287-
BRDA:342,84,0,1
288-
BRDA:343,85,0,0
289-
BRDA:345,86,0,1
290-
BRDA:350,87,0,1
291-
BRDA:353,88,0,1
292-
BRDA:354,89,0,0
293-
BRDA:356,90,0,1
294-
BRDA:361,91,0,1
295-
BRDA:364,92,0,0
296-
BRDA:362,93,0,1
297-
BRDA:363,94,0,1
298-
BRDA:367,95,0,1
299-
BRDA:370,96,0,0
300-
BRDA:368,97,0,1
301-
BRDA:369,98,0,1
302-
BRDA:375,99,0,1
303-
BRDA:379,100,0,1
304-
BRF:101
305-
BRH:97
290+
BRDA:336,83,0,1
291+
BRDA:341,84,0,1
292+
BRDA:345,85,0,1
293+
BRDA:348,86,0,1
294+
BRDA:349,87,0,0
295+
BRDA:351,88,0,1
296+
BRDA:356,89,0,1
297+
BRDA:359,90,0,1
298+
BRDA:360,91,0,0
299+
BRDA:362,92,0,1
300+
BRDA:367,93,0,1
301+
BRDA:370,94,0,0
302+
BRDA:368,95,0,1
303+
BRDA:369,96,0,1
304+
BRDA:373,97,0,1
305+
BRDA:376,98,0,0
306+
BRDA:374,99,0,1
307+
BRDA:375,100,0,1
308+
BRDA:381,101,0,1
309+
BRDA:385,102,0,1
310+
BRF:103
311+
BRH:99
306312
DA:1,1
307313
DA:2,1
308314
DA:3,1
@@ -702,6 +708,12 @@ DA:396,1
702708
DA:397,1
703709
DA:398,1
704710
DA:399,1
705-
LH:397
706-
LF:399
711+
DA:400,1
712+
DA:401,1
713+
DA:402,1
714+
DA:403,1
715+
DA:404,1
716+
DA:405,1
717+
LH:403
718+
LF:405
707719
end_of_record

‎test/fixtures/test-runner/output/output.js‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,12 +317,18 @@ test('subtest sync throw fails', async (t) => {
317317

318318
test('timed out async test', { timeout: 5 }, async (t) => {
319319
return new Promise((resolve) => {
320-
setTimeout(resolve, 100);
320+
setTimeout(() => {
321+
// Empty timer so the process doesn't exit before the timeout triggers.
322+
}, 5);
323+
setTimeout(resolve, 30_000_000).unref();
321324
});
322325
});
323326

324327
test('timed out callback test', { timeout: 5 }, (t, done) => {
325-
setTimeout(done, 100);
328+
setTimeout(() => {
329+
// Empty timer so the process doesn't exit before the timeout triggers.
330+
}, 5);
331+
setTimeout(done, 30_000_000).unref();
326332
});
327333

328334

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL