test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals · nodejs/node@97a8e05 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 97a8e05

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

RafaelGSS

committed

test: add all WebCryptoAPI globals to WPTRunner's loadLazyGlobals

PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 56f3ad1 commit 97a8e05
Copy full SHA for 97a8e05

2 files changed

+1-2Lines changed: 1 addition & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • common
    • wpt.js
  • wpt/status
    • WebCryptoAPI.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/wpt.js‎

Copy file name to clipboardExpand all lines: test/common/wpt.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -397,7 +397,7 @@ class WPTRunner {
397	397	'CompressionStream', 'DecompressionStream',
398	398	];
399	399	if (Boolean(process.versions.openssl) && !process.env.NODE_SKIP_CRYPTO) {
400		- lazyProperties.push('crypto');
	400	+ lazyProperties.push('crypto', 'Crypto', 'CryptoKey', 'SubtleCrypto');
401	401	}
402	402	const script = lazyProperties.map((name) => `globalThis.${name};`).join('\n');
403	403	this.globalThisInitScripts.push(script);

Collapse file

‎test/wpt/status/WebCryptoAPI.json‎

Copy file name to clipboardExpand all lines: test/wpt/status/WebCryptoAPI.json

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -21,7 +21,6 @@
21	21	"idlharness.https.any.js": {
22	22	"fail": {
23	23	"expected": [
24		- "Crypto interface: existence and properties of interface object",
25	24	"CryptoKey interface: existence and properties of interface object",
26	25	"Window interface: attribute crypto"
27	26	]

0 commit comments

Comments

0 (0)