test: skip test-buffer-tostring-rangeerror when low on memory · nodejs/node@97aac9f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 97aac9f

Browse filesBrowse the repository at this point in the historyBrowse files

BridgeAR

authored and

aduh95

committed

test: skip test-buffer-tostring-rangeerror when low on memory

This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low. PR-URL: #58142 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent d49fd29 commit 97aac9f
Copy full SHA for 97aac9f

1 file changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-buffer-tostring-rangeerror.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-buffer-tostring-rangeerror.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-tostring-rangeerror.js

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,10 +1,15 @@
1	1	'use strict';
2		- require('../common');
	2	+
	3	+ const common = require('../common');
3	4
4	5	// This test ensures that Node.js throws an Error when trying to convert a
5	6	// large buffer into a string.
6	7	// Regression test for https://github.com/nodejs/node/issues/649.
7	8
	9	+ if (!common.enoughTestMem) {
	10	+ common.skip('skipped due to memory requirements');
	11	+ }
	12	+
8	13	const assert = require('assert');
9	14	const {
10	15	SlowBuffer,

0 commit comments

Comments

0 (0)