Commit 97ad1a0
doc: clarify tls.tlsSocket.getCipher().version
The getCipher() returns a tuple that includes protocol version string.
This string refers to the minimum protocol version string, as per
documentation. What is missing is a reference to the documentation
where to get the negotiated cipher for the socket connection and
a clearer example.
Fixes: #43406
PR-URL: #44086
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 9e10ee7 commit 97ad1a0
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1091,17 +1091,17 @@ changes: | |||
| 1091 | 1091 | * `name` {string} OpenSSL name for the cipher suite. | |
| 1092 | 1092 | * `standardName` {string} IETF name for the cipher suite. | |
| 1093 | 1093 | * `version` {string} The minimum TLS protocol version supported by this cipher | |
| 1094 | - suite. | ||
| 1094 | + suite. For the actual negotiated protocol, see [`tls.TLSSocket.getProtocol()`][]. | ||
| 1095 | 1095 | ||
| 1096 | 1096 | Returns an object containing information on the negotiated cipher suite. | |
| 1097 | 1097 | ||
| 1098 | - For example: | ||
| 1098 | + For example, a TLSv1.2 protocol with AES256-SHA cipher: | ||
| 1099 | 1099 | ||
| 1100 | 1100 | ```json | |
| 1101 | 1101 | { | |
| 1102 | - "name": "AES128-SHA256", | ||
| 1103 | - "standardName": "TLS_RSA_WITH_AES_128_CBC_SHA256", | ||
| 1104 | - "version": "TLSv1.2" | ||
| 1102 | + "name": "AES256-SHA", | ||
| 1103 | + "standardName": "TLS_RSA_WITH_AES_256_CBC_SHA", | ||
| 1104 | + "version": "SSLv3" | ||
| 1105 | 1105 | } | |
| 1106 | 1106 | ``` | |
| 1107 | 1107 | ||
@@ -2237,6 +2237,7 @@ added: v11.4.0 | |||
| 2237 | 2237 | [`tls.Server`]: #class-tlsserver | |
| 2238 | 2238 | [`tls.TLSSocket.enableTrace()`]: #tlssocketenabletrace | |
| 2239 | 2239 | [`tls.TLSSocket.getPeerCertificate()`]: #tlssocketgetpeercertificatedetailed | |
| 2240 | + [`tls.TLSSocket.getProtocol()`]: #tlssocketgetprotocol | ||
| 2240 | 2241 | [`tls.TLSSocket.getSession()`]: #tlssocketgetsession | |
| 2241 | 2242 | [`tls.TLSSocket.getTLSTicket()`]: #tlssocketgettlsticket | |
| 2242 | 2243 | [`tls.TLSSocket`]: #class-tlstlssocket | |
0 commit comments