Commit 97e0efe
test: scale keepalive timeouts for slow machines
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)
Fixes: #30828
PR-URL: #30834
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent af01417 commit 97e0efe
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,13 +34,13 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) { | |||
| 34 | 34 | common.mustCall((req, res) => { | |
| 35 | 35 | res.end(); | |
| 36 | 36 | }, 3)); | |
| 37 | - server.setTimeout(500, common.mustCall((socket) => { | ||
| 37 | + server.setTimeout(common.platformTimeout(500), common.mustCall((socket) => { | ||
| 38 | 38 | // End this test and call `run()` for the next test (if any). | |
| 39 | 39 | socket.destroy(); | |
| 40 | 40 | server.close(); | |
| 41 | 41 | cb(); | |
| 42 | 42 | })); | |
| 43 | - server.keepAliveTimeout = 50; | ||
| 43 | + server.keepAliveTimeout = common.platformTimeout(50); | ||
| 44 | 44 | server.listen(0, common.mustCall(() => { | |
| 45 | 45 | const options = { | |
| 46 | 46 | port: server.address().port, | |
@@ -57,13 +57,13 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) { | |||
| 57 | 57 | ||
| 58 | 58 | test(function serverNoEndKeepAliveTimeoutWithPipeline(cb) { | |
| 59 | 59 | const server = https.createServer(serverOptions, common.mustCall(3)); | |
| 60 | - server.setTimeout(500, common.mustCall((socket) => { | ||
| 60 | + server.setTimeout(common.platformTimeout(500), common.mustCall((socket) => { | ||
| 61 | 61 | // End this test and call `run()` for the next test (if any). | |
| 62 | 62 | socket.destroy(); | |
| 63 | 63 | server.close(); | |
| 64 | 64 | cb(); | |
| 65 | 65 | })); | |
| 66 | - server.keepAliveTimeout = 50; | ||
| 66 | + server.keepAliveTimeout = common.platformTimeout(50); | ||
| 67 | 67 | server.listen(0, common.mustCall(() => { | |
| 68 | 68 | const options = { | |
| 69 | 69 | port: server.address().port, | |
0 commit comments