test: add `Float16Array` to `common.getArrayBufferViews()` · nodejs/node@97f8037 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 97f8037

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

targos

committed

test: add Float16Array to common.getArrayBufferViews()

PR-URL: #58233 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent a135c0a commit 97f8037
Copy full SHA for 97f8037

2 files changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • common
    • index.js
  • parallel
    • test-stream-typedarray.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -703,6 +703,7 @@ function getArrayBufferViews(buf) {
703	703	Uint16Array,
704	704	Int32Array,
705	705	Uint32Array,
	706	+ Float16Array,
706	707	Float32Array,
707	708	Float64Array,
708	709	BigInt64Array,

Collapse file

‎test/parallel/test-stream-typedarray.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stream-typedarray.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -63,7 +63,7 @@ const views = common.getArrayBufferViews(buffer);
63	63	assert.strictEqual(chunk.encoding, 'buffer');
64	64	res += chunk.chunk;
65	65	}
66		- assert.strictEqual(res, 'ABCD'.repeat(9));
	66	+ assert.strictEqual(res, 'ABCD'.repeat(views.length));
67	67	}),
68	68
69	69	});

0 commit comments

Comments

0 (0)