Commit 98b2eae
benchmark: split timers benchmark and refactor
The depth benchmark for timers sets a timer that sets a timer that sets
a timer that... 500K of them.
Since each timer has to wait for the next tick of the event loop this
benchmark takes a very long time to run compared to the breadth
test that is already in the file. This may be more of an event loop
benchmark than a timer benchmark.
Reduce the number of iterations for the depth test as it's really just
running the iterations in sequence, not in parallel. And even on an
infinitely fast machine, it would take over 8 minutes to run because
each tick of the event loop would have to wait 1ms before firing the
timer.
Split the depth and breadth benchmarks so that their `N` values can be
set independently.
Do some minor refactoring to the benchmarks (but no ES6 additions so
that the benchmarks can still be run with old versions of Node.js).
Refs: #9493
PR-URL: #9497
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>1 parent a5d27f3 commit 98b2eae
3 files changed
Lines changed: 40 additions & 41 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,20 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + var common = require('../common.js'); | ||
| 3 | + | ||
| 4 | + var bench = common.createBenchmark(main, { | ||
| 5 | + thousands: [500], | ||
| 6 | + }); | ||
| 7 | + | ||
| 8 | + function main(conf) { | ||
| 9 | + var N = +conf.thousands * 1e3; | ||
| 10 | + var n = 0; | ||
| 11 | + bench.start(); | ||
| 12 | + function cb() { | ||
| 13 | + n++; | ||
| 14 | + if (n === N) | ||
| 15 | + bench.end(N / 1e3); | ||
| 16 | + } | ||
| 17 | + for (var i = 0; i < N; i++) { | ||
| 18 | + setTimeout(cb, 1); | ||
| 19 | + } | ||
| 20 | + } | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,20 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + var common = require('../common.js'); | ||
| 3 | + | ||
| 4 | + var bench = common.createBenchmark(main, { | ||
| 5 | + thousands: [1], | ||
| 6 | + }); | ||
| 7 | + | ||
| 8 | + function main(conf) { | ||
| 9 | + var N = +conf.thousands * 1e3; | ||
| 10 | + var n = 0; | ||
| 11 | + bench.start(); | ||
| 12 | + setTimeout(cb, 1); | ||
| 13 | + function cb() { | ||
| 14 | + n++; | ||
| 15 | + if (n === N) | ||
| 16 | + bench.end(N / 1e3); | ||
| 17 | + else | ||
| 18 | + setTimeout(cb, 1); | ||
| 19 | + } | ||
| 20 | + } | ||
This file was deleted.
0 commit comments