build: skip build-ci on actions with a separate test step · nodejs/node@990da35 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 990da35

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

RafaelGSS

committed

build: skip build-ci on actions with a separate test step

When run `make run-ci` with CONFIG_FLAGS only set in prior `make build-ci`, `make run-ci` will try to rebuild everything, instead of re-use the built result from prior `make build-ci`. PR-URL: #61073 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 45903ee commit 990da35
Copy full SHA for 990da35

3 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • build-tarball.yml
  • test-linux.yml
  • test-macos.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/build-tarball.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/build-tarball.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -138,4 +138,4 @@ jobs:
138	138	- name: Build
139	139	run: make -C "$TAR_DIR" build-ci -j4 V=1
140	140	- name: Test
141		- run: make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
	141	+ run: make -C "$TAR_DIR" test-ci -j1 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"

Collapse file

‎.github/workflows/test-linux.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/test-linux.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -72,7 +72,7 @@ jobs:
72	72	- name: Build
73	73	run: make -C node build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn"
74	74	- name: Test
75		- run: make -C node run-ci -j4 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
	75	+ run: make -C node test-ci -j1 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
76	76	- name: Re-run test in a folder whose name contains unusual chars
77	77	run: |
78	78	mv node "$DIR"

Collapse file

‎.github/workflows/test-macos.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/test-macos.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -127,7 +127,7 @@ jobs:
127	127	- name: Free Space After Build
128	128	run: df -h
129	129	- name: Test
130		- run: make -C node run-ci -j$(getconf _NPROCESSORS_ONLN) V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
	130	+ run: make -C node test-ci -j1 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
131	131	- name: Re-run test in a folder whose name contains unusual chars
132	132	run: |
133	133	mv node "$DIR"

0 commit comments

Comments

0 (0)