Commit 99e6734
doc: improve best practices in onboarding-extras
PR-URL: #19315
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent 5a56327 commit 99e6734
1 file changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -142,10 +142,7 @@ to update from nodejs/node: | |||
| 142 | 142 | * `git remote update -p` OR `git fetch --all` (I prefer the former) | |
| 143 | 143 | * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`) | |
| 144 | 144 | ||
| 145 | - ## best practices | ||
| 145 | + ## Best practices | ||
| 146 | 146 | ||
| 147 | - * commit often, out to your github fork (origin), open a PR | ||
| 148 | - * when making PRs make sure to spend time on the description: | ||
| 149 | - * every moment you spend writing a good description quarters the amount of | ||
| 150 | - time it takes to understand your code. | ||
| 151 | - * usually prefer to only squash at the *end* of your work, depends on the change | ||
| 147 | + * When making PRs, spend time writing a thorough description. | ||
| 148 | + * Usually only squash at the end of your work. | ||
0 commit comments