assert: prefer reference comparison over string comparison · nodejs/node@99fb6d4 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 99fb6d4

Browse filesBrowse the repository at this point in the historyBrowse files

RaisinTen

authored and

danielleadams

committed

assert: prefer reference comparison over string comparison

Pointer comparison takes constant time and string comparison takes linear time unless there is some string interning going on, so this might be a little bit faster. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #41015 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

1 parent d8a2125 commit 99fb6d4
Copy full SHA for 99fb6d4

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • assert.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/assert.js‎

Copy file name to clipboardExpand all lines: lib/assert.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -831,7 +831,7 @@ function expectsError(stackStartFn, actual, error, message) {
831	831	details += ` (${error.name})`;
832	832	}
833	833	details += message ? `: ${message}` : '.';
834		- const fnType = stackStartFn.name === 'rejects' ? 'rejection' : 'exception';
	834	+ const fnType = stackStartFn === assert.rejects ? 'rejection' : 'exception';
835	835	innerFail({
836	836	actual: undefined,
837	837	expected: error,
@@ -878,7 +878,7 @@ function expectsNoError(stackStartFn, actual, error, message) {
878	878
879	879	if (!error || hasMatchingError(actual, error)) {
880	880	const details = message ? `: ${message}` : '.';
881		- const fnType = stackStartFn.name === 'doesNotReject' ?
	881	+ const fnType = stackStartFn === assert.doesNotReject ?
882	882	'rejection' : 'exception';
883	883	innerFail({
884	884	actual,
@@ -998,7 +998,7 @@ function internalMatch(string, regexp, message, fn) {
998	998	'regexp', 'RegExp', regexp
999	999	);
1000	1000	}
1001		- const match = fn.name === 'match';
	1001	+ const match = fn === assert.match;
1002	1002	if (typeof string !== 'string' ||
1003	1003	RegExpPrototypeTest(regexp, string) !== match) {
1004	1004	if (message instanceof Error) {

0 commit comments

Comments

0 (0)