Commit 99fdc1d
doc: add recommendations for first timers
PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>1 parent 6fbef7f commit 99fdc1d
2 files changed
Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -24,8 +24,9 @@ understand the project governance model as outlined in | |||
| 24 | 24 | ||
| 25 | 25 | ## Issues and Pull Requests | |
| 26 | 26 | ||
| 27 | - Courtesy should always be shown to individuals submitting issues and | ||
| 28 | - pull requests to the Node.js project. | ||
| 27 | + Courtesy should **always** be shown to individuals submitting issues and pull | ||
| 28 | + requests to the Node.js project. Be welcoming to first time contributors, | ||
| 29 | + identified by the GitHub  badge. | ||
| 29 | 30 | ||
| 30 | 31 | Collaborators should feel free to take full responsibility for | |
| 31 | 32 | managing issues and pull requests they feel qualified to handle, as | |
@@ -68,6 +69,9 @@ wide-reaching impact), and focused changes that affect only documentation | |||
| 68 | 69 | and/or the test suite, may be landed after a shorter delay if they have | |
| 69 | 70 | multiple approvals. | |
| 70 | 71 | ||
| 72 | + For first time contributors, ask the author if they have configured their git | ||
| 73 | + username and email to their liking as per [this guide][git-username]. | ||
| 74 | + | ||
| 71 | 75 | For non-breaking changes, if there is no disagreement amongst | |
| 72 | 76 | Collaborators, a pull request may be landed given appropriate review. | |
| 73 | 77 | Where there is discussion amongst Collaborators, consensus should be | |
@@ -362,10 +366,8 @@ The TSC should serve as the final arbiter where required. | |||
| 362 | 366 | * If you do, please force-push removing the merge. | |
| 363 | 367 | * Reasons for not using the web interface button: | |
| 364 | 368 | * The merge method will add an unnecessary merge commit. | |
| 365 | - * The rebase & merge method adds metadata to the commit title. | ||
| 366 | - * The rebase method changes the author. | ||
| 367 | 369 | * The squash & merge method has been known to add metadata to the | |
| 368 | - commit title. | ||
| 370 | + commit title (the PR #). | ||
| 369 | 371 | * If more than one author has contributed to the PR, keep the most recent | |
| 370 | 372 | author when squashing. | |
| 371 | 373 | ||
@@ -675,3 +677,4 @@ LTS working group and the Release team. | |||
| 675 | 677 | [backporting guide]: doc/guides/backporting-to-release-lines.md | |
| 676 | 678 | [Stability Index]: doc/api/documentation.md#stability-index | |
| 677 | 679 | [Enhancement Proposal]: https://github.com/nodejs/node-eps | |
| 680 | + [git-username]: https://help.github.com/articles/setting-your-username-in-git/ | ||
LoadingViewer requires iframe.
0 commit comments