Commit 9a12f71
lib: simplify IPv6 checks in isLoopback()
The checks for '[::1]' and '[0:0:0:0:0:0:0:1]'
in isLoopback were using startsWith,
which is unnecessary as these are canonical
loopback addresses with no valid prefixes.
Switching to strict equality improves
clarity and improves performance.
PR-URL: #59375
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>1 parent 52ab64e commit 9a12f71
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -93,8 +93,8 @@ function isLoopback(host) { | |||
| 93 | 93 | return ( | |
| 94 | 94 | hostLower === 'localhost' || | |
| 95 | 95 | hostLower.startsWith('127.') || | |
| 96 | - hostLower.startsWith('[::1]') || | ||
| 97 | - hostLower.startsWith('[0:0:0:0:0:0:0:1]') | ||
| 96 | + hostLower === '[::1]' || | ||
| 97 | + hostLower === '[0:0:0:0:0:0:0:1]' | ||
| 98 | 98 | ); | |
| 99 | 99 | } | |
| 100 | 100 | ||
0 commit comments