doc: clarify diffieHellman.generateKeys recomputes same key · nodejs/node@9a3a190 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9a3a190

Browse filesBrowse the repository at this point in the historyBrowse files

authored and

aduh95

committed

doc: clarify diffieHellman.generateKeys recomputes same key

Clarify that calling generateKeys() after a private key has been set recomputes the same public key deterministically, rather than implying the public key changes. The public key is fully determined by the private key, so the result is identical unless the private key was changed via setPrivateKey(). Fixes: #56990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> PR-URL: #62205 Fixes: #56990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

1 parent ef7ffce commit 9a3a190
Copy full SHA for 9a3a190

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • crypto.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/crypto.md‎

Copy file name to clipboardExpand all lines: doc/api/crypto.md

+5-2Lines changed: 5 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1393,8 +1393,10 @@ If `encoding` is provided a string is returned; otherwise a
1393	1393	[`Buffer`][] is returned.
1394	1394
1395	1395	This function is a thin wrapper around [`DH_generate_key()`][]. In particular,
1396		- once a private key has been generated or set, calling this function only updates
1397		- the public key but does not generate a new private key.
	1396	+ once a private key has been generated or set, calling this function only
	1397	+ recomputes the public key from the existing private key. Since the public key is
	1398	+ determined by the private key, the result will be the same unless the private key
	1399	+ has been changed via [`diffieHellman.setPrivateKey()`][].
1398	1400
1399	1401	### `diffieHellman.getGenerator([encoding])`
1400	1402
@@ -6907,6 +6909,7 @@ See the [list of SSL OP Flags][] for details.
6907	6909	[`decipher.final()`]: #decipherfinaloutputencoding
6908	6910	[`decipher.update()`]: #decipherupdatedata-inputencoding-outputencoding
6909	6911	[`diffieHellman.generateKeys()`]: #diffiehellmangeneratekeysencoding
	6912	+ [`diffieHellman.setPrivateKey()`]: #diffiehellmansetprivatekeyprivatekey-encoding
6910	6913	[`diffieHellman.setPublicKey()`]: #diffiehellmansetpublickeypublickey-encoding
6911	6914	[`ecdh.generateKeys()`]: #ecdhgeneratekeysencoding-format
6912	6915	[`ecdh.setPrivateKey()`]: #ecdhsetprivatekeyprivatekey-encoding

0 commit comments

Comments

0 (0)