Commit 9b03af2
http: remove reference to onParserExecute
Parsers hold a reference to the socket associated with the request
through onParserExecute. This must be removed when the parser is
freed so that the socket can be garbage collected when destroyed.
Regression introduced in commit 59b91f1 ("http_parser: consume
StreamBase instance").
PR-URL: #4773
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>1 parent 2119c76 commit 9b03af2
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,6 +20,7 @@ const kOnHeaders = HTTPParser.kOnHeaders | 0; | |||
| 20 | 20 | const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0; | |
| 21 | 21 | const kOnBody = HTTPParser.kOnBody | 0; | |
| 22 | 22 | const kOnMessageComplete = HTTPParser.kOnMessageComplete | 0; | |
| 23 | + const kOnExecute = HTTPParser.kOnExecute | 0; | ||
| 23 | 24 | ||
| 24 | 25 | // Only called in the slow case where slow means | |
| 25 | 26 | // that the request headers were either fragmented | |
@@ -151,6 +152,7 @@ var parsers = new FreeList('parsers', 1000, function() { | |||
| 151 | 152 | parser[kOnHeadersComplete] = parserOnHeadersComplete; | |
| 152 | 153 | parser[kOnBody] = parserOnBody; | |
| 153 | 154 | parser[kOnMessageComplete] = parserOnMessageComplete; | |
| 155 | + parser[kOnExecute] = null; | ||
| 154 | 156 | ||
| 155 | 157 | return parser; | |
| 156 | 158 | }); | |
@@ -175,6 +177,7 @@ function freeParser(parser, req, socket) { | |||
| 175 | 177 | parser.socket.parser = null; | |
| 176 | 178 | parser.socket = null; | |
| 177 | 179 | parser.incoming = null; | |
| 180 | + parser[kOnExecute] = null; | ||
| 178 | 181 | if (parsers.free(parser) === false) | |
| 179 | 182 | parser.close(); | |
| 180 | 183 | parser = null; | |
0 commit comments