Commit 9b3c115
committed
deps: V8: cherry-pick 3b8c624
Original commit message:
GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary
elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template
parameter. But the declaration of the template method is in js-object.cc, so nobody
can actually compile the version for number dictionary. This is fixed requesting
explicit instantiation for NumberDictionary.
This was breaking GCC build.
Bug: chromium:819294
Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#62097}
Refs: v8/v8@3b8c624
Backport-PR-URL: #28955
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent 533b2d4 commit 9b3c115
3 files changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.10', | ||
| 41 | + 'v8_embedder_string': '-node.11', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,6 +15,7 @@ NVIDIA Corporation <*@nvidia.com> | |||
| 15 | 15 | BlackBerry Limited <*@blackberry.com> | |
| 16 | 16 | Opera Software ASA <*@opera.com> | |
| 17 | 17 | Intel Corporation <*@intel.com> | |
| 18 | + LG Electronics, Inc. <*@lge.com> | ||
| 18 | 19 | Microsoft <*@microsoft.com> | |
| 19 | 20 | MIPS Technologies, Inc. <*@mips.com> | |
| 20 | 21 | Imagination Technologies, LLC <*@imgtec.com> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3752,6 +3752,10 @@ void JSObject::ApplyAttributesToDictionary( | |||
| 3752 | 3752 | } | |
| 3753 | 3753 | } | |
| 3754 | 3754 | ||
| 3755 | + template void JSObject::ApplyAttributesToDictionary( | ||
| 3756 | + Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary, | ||
| 3757 | + const PropertyAttributes attributes); | ||
| 3758 | + | ||
| 3755 | 3759 | template <PropertyAttributes attrs> | |
| 3756 | 3760 | Maybe<bool> JSObject::PreventExtensionsWithTransition( | |
| 3757 | 3761 | Handle<JSObject> object, ShouldThrow should_throw) { | |
0 commit comments