Commit 9b9762c
streams: fix regression in unpipe()
Since 2e568d9 there is a bug where unpiping a stream
from a readable stream that has `_readableState.pipesCount > 1`
will cause it to remove the first stream in the
`_.readableState.pipes` array no matter where in the list the
`dest` stream was.
This patch corrects that problem.
Ref: #9553
PR-URL: #9171
Fixes: #9170
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>1 parent 4238460 commit 9b9762c
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -664,7 +664,7 @@ Readable.prototype.unpipe = function(dest) { | |||
| 664 | 664 | if (index === -1) | |
| 665 | 665 | return this; | |
| 666 | 666 | ||
| 667 | - state.pipes.splice(i, 1); | ||
| 667 | + state.pipes.splice(index, 1); | ||
| 668 | 668 | state.pipesCount -= 1; | |
| 669 | 669 | if (state.pipesCount === 1) | |
| 670 | 670 | state.pipes = state.pipes[0]; | |
0 commit comments