Commit 9bf8874
test: make test-os-eol engine agnostic
Do not check the error message if it is generated by the JavaScript
engine (V8, ChakraCore, etc.). Do confirm that it is a `TypeError`.
PR-URL: #16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 79e1831 commit 9bf8874
1 file changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,12 +8,9 @@ const eol = common.isWindows ? '\r\n' : '\n'; | |||
| 8 | 8 | ||
| 9 | 9 | assert.strictEqual(os.EOL, eol); | |
| 10 | 10 | ||
| 11 | - common.expectsError(function() { | ||
| 12 | - os.EOL = 123; | ||
| 13 | - }, { | ||
| 14 | - type: TypeError, | ||
| 15 | - message: /^Cannot assign to read only property 'EOL' of object '#<Object>'$/ | ||
| 16 | - }); | ||
| 11 | + // Test that the `Error` is a `TypeError` but do not check the message as it | ||
| 12 | + // varies between different JavaScript engines. | ||
| 13 | + assert.throws(function() { os.EOL = 123; }, TypeError); | ||
| 17 | 14 | ||
| 18 | 15 | const foo = 'foo'; | |
| 19 | 16 | Object.defineProperties(os, { | |
0 commit comments