Commit 9d80199
src: remove unused env->vm_parsing_context_symbol
Stopped being used via 77b52fd, was
originally added in d932e80.
For the one remaining usecase inside of `lib/vm.js`, define a Symbol at
the top of the file.
PR-URL: #22034
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent e1dcb79 commit 9d80199
3 files changed
Lines changed: 1 addition & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,16 +23,15 @@ | |||
| 23 | 23 | ||
| 24 | 24 | const { | |
| 25 | 25 | ContextifyScript, | |
| 26 | - kParsingContext, | ||
| 27 | 26 | makeContext, | |
| 28 | 27 | isContext: _isContext, | |
| 29 | 28 | } = process.binding('contextify'); | |
| 30 | - | ||
| 31 | 29 | const { | |
| 32 | 30 | ERR_INVALID_ARG_TYPE, | |
| 33 | 31 | ERR_OUT_OF_RANGE | |
| 34 | 32 | } = require('internal/errors').codes; | |
| 35 | 33 | const { isUint8Array } = require('internal/util/types'); | |
| 34 | + const kParsingContext = Symbol('script parsing context'); | ||
| 36 | 35 | ||
| 37 | 36 | class Script extends ContextifyScript { | |
| 38 | 37 | constructor(code, options = {}) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -346,7 +346,6 @@ struct PackageConfig { | |||
| 346 | 346 | V(tls_wrap_constructor_function, v8::Function) \ | |
| 347 | 347 | V(tty_constructor_template, v8::FunctionTemplate) \ | |
| 348 | 348 | V(udp_constructor_function, v8::Function) \ | |
| 349 | - V(vm_parsing_context_symbol, v8::Symbol) \ | ||
| 350 | 349 | V(url_constructor_function, v8::Function) \ | |
| 351 | 350 | V(write_wrap_template, v8::ObjectTemplate) | |
| 352 | 351 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -608,16 +608,6 @@ class ContextifyScript : public BaseObject { | |||
| 608 | 608 | ||
| 609 | 609 | target->Set(class_name, script_tmpl->GetFunction()); | |
| 610 | 610 | env->set_script_context_constructor_template(script_tmpl); | |
| 611 | - | ||
| 612 | - Local<Symbol> parsing_context_symbol = | ||
| 613 | - Symbol::New(env->isolate(), | ||
| 614 | - FIXED_ONE_BYTE_STRING(env->isolate(), | ||
| 615 | - "script parsing context")); | ||
| 616 | - env->set_vm_parsing_context_symbol(parsing_context_symbol); | ||
| 617 | - target->Set(env->context(), | ||
| 618 | - FIXED_ONE_BYTE_STRING(env->isolate(), "kParsingContext"), | ||
| 619 | - parsing_context_symbol) | ||
| 620 | - .FromJust(); | ||
| 621 | 611 | } | |
| 622 | 612 | ||
| 623 | 613 | ||
0 commit comments