Commit 9d8d7c6
test: do not OR F_OK in fs.access() test
access() does not support OR'ing F_OK with other constants.
This commit updates test-fs-access.js to not test that
scenario.
PR-URL: #41484
Refs: libuv/libuv#3410
Reviewed-By: Richard Lau
Reviewed-By: Luigi Pinca
Reviewed-By: Tobias Nießen1 parent af3acec commit 9d8d7c6
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -82,10 +82,10 @@ fs.access(__filename, fs.R_OK, common.mustCall(function(...args) { | |||
| 82 | 82 | fs.promises.access(__filename, fs.R_OK) | |
| 83 | 83 | .then(common.mustCall()) | |
| 84 | 84 | .catch(throwNextTick); | |
| 85 | - fs.access(readOnlyFile, fs.F_OK | fs.R_OK, common.mustCall(function(...args) { | ||
| 85 | + fs.access(readOnlyFile, fs.R_OK, common.mustCall(function(...args) { | ||
| 86 | 86 | assert.deepStrictEqual(args, [null]); | |
| 87 | 87 | })); | |
| 88 | - fs.promises.access(readOnlyFile, fs.F_OK | fs.R_OK) | ||
| 88 | + fs.promises.access(readOnlyFile, fs.R_OK) | ||
| 89 | 89 | .then(common.mustCall()) | |
| 90 | 90 | .catch(throwNextTick); | |
| 91 | 91 | ||
@@ -153,7 +153,7 @@ assert.throws( | |||
| 153 | 153 | ||
| 154 | 154 | // Regular access should not throw. | |
| 155 | 155 | fs.accessSync(__filename); | |
| 156 | - const mode = fs.F_OK | fs.R_OK | fs.W_OK; | ||
| 156 | + const mode = fs.R_OK | fs.W_OK; | ||
| 157 | 157 | fs.accessSync(readWriteFile, mode); | |
| 158 | 158 | ||
| 159 | 159 | // Invalid modes should throw. | |
0 commit comments