test: avoid flaky restart sync in debugger exceptions test · nodejs/node@9dafe1d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9dafe1d

Browse filesBrowse the repository at this point in the historyBrowse files

inoway46

authored and

aduh95

committed

test: avoid flaky restart sync in debugger exceptions test

Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: #62055 Refs: #61762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

1 parent 989b2de commit 9dafe1d
Copy full SHA for 9dafe1d

1 file changed

+9-3Lines changed: 9 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-debugger-exceptions.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-debugger-exceptions.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debugger-exceptions.js

+9-3Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -27,8 +27,10 @@ const path = require('path');
27	27	await cli.waitFor(/disconnect/);
28	28
29	29	// Next run: With `breakOnException` it pauses in both places.
30		- await cli.stepCommand('r');
	30	+ await cli.command('r');
	31	+ await cli.waitFor(/ ok\n/);
31	32	await cli.waitForInitialBreak();
	33	+ await cli.waitForPrompt();
32	34	assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
33	35	await cli.command('breakOnException');
34	36	await cli.stepCommand('c');
@@ -38,16 +40,20 @@ const path = require('path');
38	40
39	41	// Next run: With `breakOnUncaught` it only pauses on the 2nd exception.
40	42	await cli.command('breakOnUncaught');
41		- await cli.stepCommand('r'); // Also, the setting survives the restart.
	43	+ await cli.command('r'); // Also, the setting survives the restart.
	44	+ await cli.waitFor(/ ok\n/);
42	45	await cli.waitForInitialBreak();
	46	+ await cli.waitForPrompt();
43	47	assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
44	48	await cli.stepCommand('c');
45	49	assert.ok(cli.output.includes(`exception in ${script}:9`));
46	50
47	51	// Next run: Back to the initial state! It should die again.
48	52	await cli.command('breakOnNone');
49		- await cli.stepCommand('r');
	53	+ await cli.command('r');
	54	+ await cli.waitFor(/ ok\n/);
50	55	await cli.waitForInitialBreak();
	56	+ await cli.waitForPrompt();
51	57	assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
52	58	await cli.command('c');
53	59	await cli.waitFor(/disconnect/);

0 commit comments

Comments

0 (0)