Commit 9e4ce6f
test: refactor test-async-wrap-*
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`
PR-URL: #9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>1 parent 3130414 commit 9e4ce6f
4 files changed
Lines changed: 18 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -41,7 +41,7 @@ async_wrap.setupHooks({ init }); | |||
| 41 | 41 | async_wrap.enable(); | |
| 42 | 42 | ||
| 43 | 43 | ||
| 44 | - setTimeout(function() { }); | ||
| 44 | + setTimeout(function() { }, 1); | ||
| 45 | 45 | ||
| 46 | 46 | fs.stat(__filename, noop); | |
| 47 | 47 | ||
Lines changed: 7 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,12 +18,12 @@ function init(uid, type, parentUid, parentHandle) { | |||
| 18 | 18 | cntr++; | |
| 19 | 19 | // Cannot assert in init callback or will abort. | |
| 20 | 20 | process.nextTick(() => { | |
| 21 | - assert.equal(providers[type], 'TCPWRAP'); | ||
| 22 | - assert.equal(parentUid, server._handle[uidSymbol], | ||
| 23 | - 'server uid doesn\'t match parent uid'); | ||
| 24 | - assert.equal(parentHandle, server._handle, | ||
| 25 | - 'server handle doesn\'t match parent handle'); | ||
| 26 | - assert.equal(this, client._handle, 'client doesn\'t match context'); | ||
| 21 | + assert.strictEqual(providers[type], 'TCPWRAP'); | ||
| 22 | + assert.strictEqual(parentUid, server._handle[uidSymbol], | ||
| 23 | + 'server uid doesn\'t match parent uid'); | ||
| 24 | + assert.strictEqual(parentHandle, server._handle, | ||
| 25 | + 'server handle doesn\'t match parent handle'); | ||
| 26 | + assert.strictEqual(this, client._handle, 'client doesn\'t match context'); | ||
| 27 | 27 | }); | |
| 28 | 28 | } | |
| 29 | 29 | } | |
@@ -48,5 +48,5 @@ async_wrap.disable(); | |||
| 48 | 48 | ||
| 49 | 49 | process.on('exit', function() { | |
| 50 | 50 | // init should have only been called once with a parent. | |
| 51 | - assert.equal(cntr, 1); | ||
| 51 | + assert.strictEqual(cntr, 1); | ||
| 52 | 52 | }); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,12 +18,12 @@ function init(uid, type, parentUid, parentHandle) { | |||
| 18 | 18 | cntr++; | |
| 19 | 19 | // Cannot assert in init callback or will abort. | |
| 20 | 20 | process.nextTick(() => { | |
| 21 | - assert.equal(providers[type], 'TCPWRAP'); | ||
| 22 | - assert.equal(parentUid, server._handle[uidSymbol], | ||
| 23 | - 'server uid doesn\'t match parent uid'); | ||
| 24 | - assert.equal(parentHandle, server._handle, | ||
| 25 | - 'server handle doesn\'t match parent handle'); | ||
| 26 | - assert.equal(this, client._handle, 'client doesn\'t match context'); | ||
| 21 | + assert.strictEqual(providers[type], 'TCPWRAP'); | ||
| 22 | + assert.strictEqual(parentUid, server._handle[uidSymbol], | ||
| 23 | + 'server uid doesn\'t match parent uid'); | ||
| 24 | + assert.strictEqual(parentHandle, server._handle, | ||
| 25 | + 'server handle doesn\'t match parent handle'); | ||
| 26 | + assert.strictEqual(this, client._handle, 'client doesn\'t match context'); | ||
| 27 | 27 | }); | |
| 28 | 28 | } | |
| 29 | 29 | } | |
@@ -47,5 +47,5 @@ const server = net.createServer(function(c) { | |||
| 47 | 47 | ||
| 48 | 48 | process.on('exit', function() { | |
| 49 | 49 | // init should have only been called once with a parent. | |
| 50 | - assert.equal(cntr, 1); | ||
| 50 | + assert.strictEqual(cntr, 1); | ||
| 51 | 51 | }); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,8 +40,8 @@ if (typeof process.argv[2] === 'string') { | |||
| 40 | 40 | } else { | |
| 41 | 41 | ||
| 42 | 42 | process.on('exit', (code) => { | |
| 43 | - assert.equal(msgCalled, callbacks.length); | ||
| 44 | - assert.equal(msgCalled, msgReceived); | ||
| 43 | + assert.strictEqual(msgCalled, callbacks.length); | ||
| 44 | + assert.strictEqual(msgCalled, msgReceived); | ||
| 45 | 45 | }); | |
| 46 | 46 | ||
| 47 | 47 | callbacks.forEach((item) => { | |
@@ -58,7 +58,7 @@ if (typeof process.argv[2] === 'string') { | |||
| 58 | 58 | if (errstring.includes('Error: ' + item)) | |
| 59 | 59 | msgReceived++; | |
| 60 | 60 | ||
| 61 | - assert.equal(code, 1, `${item} closed with code ${code}`); | ||
| 61 | + assert.strictEqual(code, 1, `${item} closed with code ${code}`); | ||
| 62 | 62 | }); | |
| 63 | 63 | }); | |
| 64 | 64 | } | |
0 commit comments