Commit 9e83c00
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -263,6 +263,19 @@ branch. | |||
| 263 | 263 | $ git checkout -b v1.2.3-proposal upstream/v1.x-staging | |
| 264 | 264 | ``` | |
| 265 | 265 | ||
| 266 | + <details> | ||
| 267 | + <summary>Security release</summary> | ||
| 268 | + | ||
| 269 | + When performing Security Releases, the `vN.x.x-proposal` branch should be | ||
| 270 | + branched off of `vN.x`. | ||
| 271 | + | ||
| 272 | + ```console | ||
| 273 | + $ git checkout -b v1.2.3-proposal upstream/v1.x | ||
| 274 | + git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal | ||
| 275 | + ``` | ||
| 276 | + | ||
| 277 | + </details> | ||
| 278 | + | ||
| 266 | 279 | ### 3. Update `src/node_version.h` | |
| 267 | 280 | ||
| 268 | 281 | Set the version for the proposed release using the following macros, which are | |
@@ -458,6 +471,9 @@ Notable changes: | |||
| 458 | 471 | PR-URL: TBD | |
| 459 | 472 | ``` | |
| 460 | 473 | ||
| 474 | + **Note**: Ensure to push the proposal branch to the nodejs-private repository. | ||
| 475 | + Otherwise, you will leak the commits before the security release. | ||
| 476 | + | ||
| 461 | 477 | </details> | |
| 462 | 478 | ||
| 463 | 479 | ### 6. Propose release on GitHub | |
0 commit comments