Commit 9ece63d
tools: do not run Corepack code before it's reviewed
Also enable running `make corepack-update` when `node`/`npm` is not
available globally.
PR-URL: #53405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c7d44ba commit 9ece63d
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1151,13 +1151,14 @@ pkg: $(PKG) | |||
| 1151 | 1151 | .PHONY: corepack-update | |
| 1152 | 1152 | corepack-update: | |
| 1153 | 1153 | mkdir -p /tmp/node-corepack | |
| 1154 | - curl -qLo /tmp/node-corepack/package.tgz "$$(npm view corepack dist.tarball)" | ||
| 1154 | + curl -qLo /tmp/node-corepack/package.tgz "$$($(call available-node,$(NPM) view corepack dist.tarball))" | ||
| 1155 | 1155 | ||
| 1156 | 1156 | rm -rf deps/corepack && mkdir deps/corepack | |
| 1157 | 1157 | cd deps/corepack && tar xf /tmp/node-corepack/package.tgz --strip-components=1 | |
| 1158 | 1158 | chmod +x deps/corepack/shims/* | |
| 1159 | 1159 | ||
| 1160 | - node deps/corepack/dist/corepack.js --version | ||
| 1160 | + $(call available-node,'-p' \ | ||
| 1161 | + 'require(`./deps/corepack/package.json`).version') | ||
| 1161 | 1162 | ||
| 1162 | 1163 | .PHONY: pkg-upload | |
| 1163 | 1164 | # Note: this is strictly for release builds on release machines only. | |
0 commit comments