Commit 9f13b5f
tools: forbid template literals in assert.throws
Extend the assert-throws-arguments custom ESLint rule to also check for
the use of template literals as a second argument to assert.throws.
PR-URL: #10301
Ref: #10282 (comment)
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Italo A. Casas <me@italoacasas.com>1 parent c801de9 commit 9f13b5f
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -21,7 +21,8 @@ function checkThrowsArguments(context, node) { | |||
| 21 | 21 | }); | |
| 22 | 22 | } else if (args.length > 1) { | |
| 23 | 23 | const error = args[1]; | |
| 24 | - if (error.type === 'Literal' && typeof error.value === 'string') { | ||
| 24 | + if (error.type === 'Literal' && typeof error.value === 'string' || | ||
| 25 | + error.type === 'TemplateLiteral') { | ||
| 25 | 26 | context.report({ | |
| 26 | 27 | message: 'Unexpected string as second argument', | |
| 27 | 28 | node: error | |
0 commit comments