Commit 9ffdee8
benchmark: use unique filenames in fs benchmarks
Use a unique file name for each benchmark. Running benchmarks
simultaneously may be a bit of an unusual use case, but there are use
cases, such as stress testing `test/parallel/test-benchmark-fs.js`.
PR-URL: #16776
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b931169 commit 9ffdee8
3 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,8 @@ | |||
| 3 | 3 | ||
| 4 | 4 | const path = require('path'); | |
| 5 | 5 | const common = require('../common.js'); | |
| 6 | - const filename = path.resolve(__dirname, '.removeme-benchmark-garbage'); | ||
| 6 | + const filename = path.resolve(__dirname, | ||
| 7 | + `.removeme-benchmark-garbage-${process.pid}`); | ||
| 7 | 8 | const fs = require('fs'); | |
| 8 | 9 | const assert = require('assert'); | |
| 9 | 10 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,7 +5,8 @@ | |||
| 5 | 5 | ||
| 6 | 6 | const path = require('path'); | |
| 7 | 7 | const common = require('../common.js'); | |
| 8 | - const filename = path.resolve(__dirname, '.removeme-benchmark-garbage'); | ||
| 8 | + const filename = path.resolve(__dirname, | ||
| 9 | + `.removeme-benchmark-garbage-${process.pid}`); | ||
| 9 | 10 | const fs = require('fs'); | |
| 10 | 11 | ||
| 11 | 12 | const bench = common.createBenchmark(main, { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,8 @@ | |||
| 3 | 3 | ||
| 4 | 4 | const path = require('path'); | |
| 5 | 5 | const common = require('../common.js'); | |
| 6 | - const filename = path.resolve(__dirname, '.removeme-benchmark-garbage'); | ||
| 6 | + const filename = path.resolve(__dirname, | ||
| 7 | + `.removeme-benchmark-garbage-${process.pid}`); | ||
| 7 | 8 | const fs = require('fs'); | |
| 8 | 9 | ||
| 9 | 10 | const bench = common.createBenchmark(main, { | |
0 commit comments