test: fix test-vm-memleak for high baseline platforms · nodejs/node@a0492ba · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a0492ba

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

jasnell

committed

test: fix test-vm-memleak for high baseline platforms

test-vm-memleak always fails on AIX in CI because the test checks that total memory consumption is less than 64 Mb, but AIX uses over 100 Mb just as a baseline. So instead, let's compare the memory consumption to the baseline and make sure it is within 32 Mb. PR-URL: #38062 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 30d7f05 commit a0492ba
Copy full SHA for a0492ba

1 file changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/pummel
  • test-vm-memleak.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/pummel/test-vm-memleak.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-vm-memleak.js

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -26,6 +26,8 @@ require('../common');
26	26	const assert = require('assert');
27	27	const vm = require('vm');
28	28
	29	+ const baselineRss = process.memoryUsage.rss();
	30	+
29	31	const start = Date.now();
30	32
31	33	const interval = setInterval(function() {
@@ -36,8 +38,8 @@ const interval = setInterval(function() {
36	38
37	39	global.gc();
38	40	const rss = process.memoryUsage.rss();
39		- assert.ok(rss < 64 * 1024 * 1024,
40		- `memory usage: ${rss} (${Math.round(rss / (1024 * 1024))} MB)`);
	41	+ assert.ok(rss < baselineRss + 32 * 1024 * 1024,
	42	+ `memory usage: ${rss} baseline: ${baselineRss}`);
41	43
42	44	// Stop after 5 seconds.
43	45	if (Date.now() - start > 5 * 1000) {

0 commit comments

Comments

0 (0)