Commit a086604
test: remove 3rd arg from to assert.strictEqual()
prevents AssertionError from reporting string literal,
instead displays values of first 2 args passed to
assert.strictEqual()
PR-URL: #21828
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 6487d8d commit a086604
1 file changed
Lines changed: 20 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,42 +59,52 @@ The order things are called | |||
| 59 | 59 | const t = new stream.Transform({ | |
| 60 | 60 | objectMode: true, | |
| 61 | 61 | transform: common.mustCall(function(chunk, _, next) { | |
| 62 | - assert.strictEqual(++state, chunk, 'transformCallback part 1'); | ||
| 62 | + // transformCallback part 1 | ||
| 63 | + assert.strictEqual(++state, chunk); | ||
| 63 | 64 | this.push(state); | |
| 64 | - assert.strictEqual(++state, chunk + 2, 'transformCallback part 2'); | ||
| 65 | + // transformCallback part 2 | ||
| 66 | + assert.strictEqual(++state, chunk + 2); | ||
| 65 | 67 | process.nextTick(next); | |
| 66 | 68 | }, 3), | |
| 67 | 69 | final: common.mustCall(function(done) { | |
| 68 | 70 | state++; | |
| 69 | - assert.strictEqual(state, 10, 'finalCallback part 1'); | ||
| 71 | + // finalCallback part 1 | ||
| 72 | + assert.strictEqual(state, 10); | ||
| 70 | 73 | state++; | |
| 71 | - assert.strictEqual(state, 11, 'finalCallback part 2'); | ||
| 74 | + // finalCallback part 2 | ||
| 75 | + assert.strictEqual(state, 11); | ||
| 72 | 76 | done(); | |
| 73 | 77 | }, 1), | |
| 74 | 78 | flush: common.mustCall(function(done) { | |
| 75 | 79 | state++; | |
| 76 | - assert.strictEqual(state, 12, 'flushCallback part 1'); | ||
| 80 | + // fluchCallback part 1 | ||
| 81 | + assert.strictEqual(state, 12); | ||
| 77 | 82 | process.nextTick(function() { | |
| 78 | 83 | state++; | |
| 79 | - assert.strictEqual(state, 15, 'flushCallback part 2'); | ||
| 84 | + // fluchCallback part 2 | ||
| 85 | + assert.strictEqual(state, 15); | ||
| 80 | 86 | done(); | |
| 81 | 87 | }); | |
| 82 | 88 | }, 1) | |
| 83 | 89 | }); | |
| 84 | 90 | t.on('finish', common.mustCall(function() { | |
| 85 | 91 | state++; | |
| 86 | - assert.strictEqual(state, 13, 'finishListener'); | ||
| 92 | + // finishListener | ||
| 93 | + assert.strictEqual(state, 13); | ||
| 87 | 94 | }, 1)); | |
| 88 | 95 | t.on('end', common.mustCall(function() { | |
| 89 | 96 | state++; | |
| 90 | - assert.strictEqual(state, 16, 'end event'); | ||
| 97 | + // endEvent | ||
| 98 | + assert.strictEqual(state, 16); | ||
| 91 | 99 | }, 1)); | |
| 92 | 100 | t.on('data', common.mustCall(function(d) { | |
| 93 | - assert.strictEqual(++state, d + 1, 'dataListener'); | ||
| 101 | + // dataListener | ||
| 102 | + assert.strictEqual(++state, d + 1); | ||
| 94 | 103 | }, 3)); | |
| 95 | 104 | t.write(1); | |
| 96 | 105 | t.write(4); | |
| 97 | 106 | t.end(7, common.mustCall(function() { | |
| 98 | 107 | state++; | |
| 99 | - assert.strictEqual(state, 14, 'endMethodCallback'); | ||
| 108 | + // endMethodCallback | ||
| 109 | + assert.strictEqual(state, 14); | ||
| 100 | 110 | }, 1)); | |
0 commit comments