test: fix test-debugger-profile for coverage generation · nodejs/node@a0b36e3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a0b36e3

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

richardlau

committed

test: fix test-debugger-profile for coverage generation

The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

1 parent dd0f164 commit a0b36e3
Copy full SHA for a0b36e3

1 file changed

+8-1Lines changed: 8 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-debugger-profile.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-debugger-profile.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debugger-profile.js

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -14,7 +14,14 @@ function delay(ms) {
14	14
15	15	// Profiles.
16	16	{
17		- const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
	17	+ const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')], [], {
	18	+ env: {
	19	+ ...process.env,
	20	+ // When this test is run with NODE_V8_COVERAGE, it clobbers the inspector
	21	+ // output, so override to disable coverage for the child process.
	22	+ NODE_V8_COVERAGE: undefined,
	23	+ }
	24	+ });
18	25
19	26	function onFatal(error) {
20	27	cli.quit();

0 commit comments

Comments

0 (0)