test: remove timeout in test-https-proxy-request-handshake-failure · nodejs/node@a0d22e9 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a0d22e9

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

aduh95

committed

test: remove timeout in test-https-proxy-request-handshake-failure

The timeout is unnecessary since we are testing for certificate failure. It can cause flakes on very slow machines where the request cannot be finished in 1 second. PR-URL: #59165 Fixes: #59166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 28538f2 commit a0d22e9
Copy full SHA for a0d22e9

1 file changed

-1Lines changed: 0 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/client-proxy
  • test-https-proxy-request-handshake-failure.mjs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/client-proxy/test-https-proxy-request-handshake-failure.mjs‎

Copy file name to clipboardExpand all lines: test/client-proxy/test-https-proxy-request-handshake-failure.mjs

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -33,7 +33,6 @@ const requestUrl = `https://${serverHost}/test`;
33	33	const { code, signal, stderr, stdout } = await runProxiedRequest({
34	34	NODE_USE_ENV_PROXY: 1,
35	35	REQUEST_URL: requestUrl,
36		- REQUEST_TIMEOUT: 1000,
37	36	HTTPS_PROXY: `http://localhost:${proxy.address().port}`,
38	37	});
39	38

0 commit comments

Comments

0 (0)