test: refactor test using assert instead of try/catch · nodejs/node@a0f89a2 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a0f89a2

Browse filesBrowse the repository at this point in the historyBrowse files

juansb827

authored and

targos

committed

test: refactor test using assert instead of try/catch

PR-URL: #28346 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

1 parent 32cf344 commit a0f89a2
Copy full SHA for a0f89a2

1 file changed

+13-13Lines changed: 13 additions & 13 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/pseudo-tty
  • test-assert-no-color.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/pseudo-tty/test-assert-no-color.js‎

Copy file name to clipboardExpand all lines: test/pseudo-tty/test-assert-no-color.js

+13-13Lines changed: 13 additions & 13 deletions

Original file line number	Diff line number	Diff line change
@@ -4,16 +4,16 @@ const assert = require('assert').strict;
4	4
5	5	process.env.NODE_DISABLE_COLORS = true;
6	6
7		- try {
8		- assert.deepStrictEqual({}, { foo: 'bar' });
9		- } catch (error) {
10		- const expected =
11		- 'Expected values to be strictly deep-equal:\n' +
12		- '+ actual - expected\n' +
13		- '\n' +
14		- '+ {}\n' +
15		- '- {\n' +
16		- '- foo: \'bar\'\n' +
17		- '- }';
18		- assert.strictEqual(error.message, expected);
19		- }
	7	+ assert.throws(
	8	+ () => {
	9	+ assert.deepStrictEqual({}, { foo: 'bar' });
	10	+ },
	11	+ {
	12	+ message: 'Expected values to be strictly deep-equal:\n' +
	13	+ '+ actual - expected\n' +
	14	+ '\n' +
	15	+ '+ {}\n' +
	16	+ '- {\n' +
	17	+ '- foo: \'bar\'\n' +
	18	+ '- }'
	19	+ });

0 commit comments

Comments

0 (0)