Commit a10c355
benchmark: add trailing commas in benchmark/http2
PR-URL: #46552
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 9567436 commit a10c355
6 files changed
Lines changed: 11 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,6 @@ overrides: | |||
| 11 | 11 | - files: | |
| 12 | 12 | - crypto/*.js | |
| 13 | 13 | - http/*.js | |
| 14 | - - http2/*.js | ||
| 15 | 14 | - path/*.js | |
| 16 | 15 | - url/*.js | |
| 17 | 16 | rules: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, { | |||
| 10 | 10 | streams: [1, 10, 20, 40, 100, 200], | |
| 11 | 11 | clients: [2], | |
| 12 | 12 | benchmarker: ['test-double-http2'], | |
| 13 | - duration: 5 | ||
| 13 | + duration: 5, | ||
| 14 | 14 | }, { flags: ['--no-warnings'] }); | |
| 15 | 15 | ||
| 16 | 16 | function main({ requests, streams, clients, duration }) { | |
@@ -32,7 +32,7 @@ function main({ requests, streams, clients, duration }) { | |||
| 32 | 32 | maxConcurrentStreams: streams, | |
| 33 | 33 | clients, | |
| 34 | 34 | threads: clients, | |
| 35 | - duration | ||
| 35 | + duration, | ||
| 36 | 36 | }, () => { server.close(); }); | |
| 37 | 37 | }); | |
| 38 | 38 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,13 +4,13 @@ const common = require('../common.js'); | |||
| 4 | 4 | ||
| 5 | 5 | const bench = common.createBenchmark(main, { | |
| 6 | 6 | n: [1e3], | |
| 7 | - nheaders: [0, 10, 100, 1000] | ||
| 7 | + nheaders: [0, 10, 100, 1000], | ||
| 8 | 8 | }, { flags: ['--no-warnings'] }); | |
| 9 | 9 | ||
| 10 | 10 | function main({ n, nheaders }) { | |
| 11 | 11 | const http2 = require('http2'); | |
| 12 | 12 | const server = http2.createServer({ | |
| 13 | - maxHeaderListPairs: 20000 | ||
| 13 | + maxHeaderListPairs: 20000, | ||
| 14 | 14 | }); | |
| 15 | 15 | ||
| 16 | 16 | const headersObject = { | |
@@ -20,7 +20,7 @@ function main({ n, nheaders }) { | |||
| 20 | 20 | 'accept-language': 'en', | |
| 21 | 21 | 'content-type': 'text/plain', | |
| 22 | 22 | 'referer': 'https://example.org/', | |
| 23 | - 'user-agent': 'SuperBenchmarker 3000' | ||
| 23 | + 'user-agent': 'SuperBenchmarker 3000', | ||
| 24 | 24 | }; | |
| 25 | 25 | ||
| 26 | 26 | for (let i = 0; i < nheaders; i++) { | |
@@ -33,7 +33,7 @@ function main({ n, nheaders }) { | |||
| 33 | 33 | }); | |
| 34 | 34 | server.listen(0, () => { | |
| 35 | 35 | const client = http2.connect(`http://localhost:${server.address().port}/`, { | |
| 36 | - maxHeaderListPairs: 20000 | ||
| 36 | + maxHeaderListPairs: 20000, | ||
| 37 | 37 | }); | |
| 38 | 38 | ||
| 39 | 39 | function doRequest(remaining) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,7 @@ const bench = common.createBenchmark(main, { | |||
| 11 | 11 | streams: [1, 10, 20, 40, 100, 200], | |
| 12 | 12 | clients: [2], | |
| 13 | 13 | benchmarker: ['test-double-http2'], | |
| 14 | - duration: 5 | ||
| 14 | + duration: 5, | ||
| 15 | 15 | }, { flags: ['--no-warnings'] }); | |
| 16 | 16 | ||
| 17 | 17 | function main({ requests, streams, clients, duration }) { | |
@@ -33,7 +33,7 @@ function main({ requests, streams, clients, duration }) { | |||
| 33 | 33 | maxConcurrentStreams: streams, | |
| 34 | 34 | clients, | |
| 35 | 35 | duration, | |
| 36 | - threads: clients | ||
| 36 | + threads: clients, | ||
| 37 | 37 | }, () => server.close()); | |
| 38 | 38 | }); | |
| 39 | 39 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, { | |||
| 10 | 10 | streams: [1, 10, 20, 40, 100, 200], | |
| 11 | 11 | clients: [2], | |
| 12 | 12 | benchmarker: ['test-double-http2'], | |
| 13 | - duration: 5 | ||
| 13 | + duration: 5, | ||
| 14 | 14 | }, { flags: ['--no-warnings'] }); | |
| 15 | 15 | ||
| 16 | 16 | function main({ requests, streams, clients, duration }) { | |
@@ -30,7 +30,7 @@ function main({ requests, streams, clients, duration }) { | |||
| 30 | 30 | maxConcurrentStreams: streams, | |
| 31 | 31 | clients, | |
| 32 | 32 | duration, | |
| 33 | - threads: clients | ||
| 33 | + threads: clients, | ||
| 34 | 34 | }, () => { server.close(); }); | |
| 35 | 35 | }); | |
| 36 | 36 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, { | |||
| 7 | 7 | length: [64 * 1024, 128 * 1024, 256 * 1024, 1024 * 1024], | |
| 8 | 8 | size: [100000], | |
| 9 | 9 | benchmarker: ['test-double-http2'], | |
| 10 | - duration: 5 | ||
| 10 | + duration: 5, | ||
| 11 | 11 | }, { flags: ['--no-warnings'] }); | |
| 12 | 12 | ||
| 13 | 13 | function main({ streams, length, size, duration }) { | |
0 commit comments