Commit a139f5d
test: fix multiple incorrect mustNotCall() uses
This does not fix occurrences in test/parallel/test-dns-* because those
tests contain unrelated pre-existing bugs that would cause the tests to
fail with this fix. This unrelated bug in those tests should be fixed
separately before the use of mustNotCall() can be fixed in those files.
PR-URL: #44022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 6990833 commit a139f5d
5 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,7 +15,7 @@ const stream = new Writable({ | |||
| 15 | 15 | }); | |
| 16 | 16 | const myConsole = new Console(stream, stream); | |
| 17 | 17 | ||
| 18 | - process.on('warning', common.mustNotCall); | ||
| 18 | + process.on('warning', common.mustNotCall()); | ||
| 19 | 19 | ||
| 20 | 20 | stream.cork(); | |
| 21 | 21 | for (let i = 0; i < EventEmitter.defaultMaxListeners + 1; i++) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -141,7 +141,7 @@ function onSession(session, next) { | |||
| 141 | 141 | ||
| 142 | 142 | function testNoTls() { | |
| 143 | 143 | // HTTP/1.1 client | |
| 144 | - get(Object.assign(parse(origin), clientOptions), common.mustNotCall) | ||
| 144 | + get(Object.assign(parse(origin), clientOptions), common.mustNotCall()) | ||
| 145 | 145 | .on('error', common.mustCall(cleanup)) | |
| 146 | 146 | .on('error', common.mustCall(testWrongALPN)) | |
| 147 | 147 | .end(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -124,7 +124,7 @@ const Readable = require('stream').Readable; | |||
| 124 | 124 | assert.strictEqual(state.reading, false); | |
| 125 | 125 | assert.strictEqual(state.readingMore, false); | |
| 126 | 126 | ||
| 127 | - const onReadable = common.mustNotCall; | ||
| 127 | + const onReadable = common.mustNotCall(); | ||
| 128 | 128 | ||
| 129 | 129 | readable.on('readable', onReadable); | |
| 130 | 130 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -53,7 +53,7 @@ nonStringInputs.forEach(common.mustCall((input) => { | |||
| 53 | 53 | ||
| 54 | 54 | unzips.forEach(common.mustCall((uz, i) => { | |
| 55 | 55 | uz.on('error', common.mustCall()); | |
| 56 | - uz.on('end', common.mustNotCall); | ||
| 56 | + uz.on('end', common.mustNotCall()); | ||
| 57 | 57 | ||
| 58 | 58 | // This will trigger error event | |
| 59 | 59 | uz.write('this is not valid compressed data.'); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,12 +7,12 @@ const message = 'Come on, Fhqwhgads.'; | |||
| 7 | 7 | const buffer = Buffer.from(message); | |
| 8 | 8 | ||
| 9 | 9 | const zipper = new zlib.Gzip(); | |
| 10 | - zipper.on('close', common.mustNotCall); | ||
| 10 | + zipper.on('close', common.mustNotCall()); | ||
| 11 | 11 | ||
| 12 | 12 | const zipped = zipper._processChunk(buffer, zlib.constants.Z_FINISH); | |
| 13 | 13 | ||
| 14 | 14 | const unzipper = new zlib.Gunzip(); | |
| 15 | - unzipper.on('close', common.mustNotCall); | ||
| 15 | + unzipper.on('close', common.mustNotCall()); | ||
| 16 | 16 | ||
| 17 | 17 | const unzipped = unzipper._processChunk(zipped, zlib.constants.Z_FINISH); | |
| 18 | 18 | assert.notStrictEqual(zipped.toString(), message); | |
0 commit comments