Commit a1539e5
http2: simplify onSelectPadding
`OnCallbackPadding` on the native side already clamps
the return value into the right range, so there’s not need
to also do that on the JS side.
Also, use `>>> 0` instead of `| 0` to get an uint32, since
the communication with C++ land happens through an Uint32Array.
Backport-PR-URL: #20456
PR-URL: #17717
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 54442ef commit a1539e5
1 file changed
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -353,11 +353,7 @@ function onSelectPadding(fn) { | |||
| 353 | 353 | return function getPadding() { | |
| 354 | 354 | const frameLen = paddingBuffer[PADDING_BUF_FRAME_LENGTH]; | |
| 355 | 355 | const maxFramePayloadLen = paddingBuffer[PADDING_BUF_MAX_PAYLOAD_LENGTH]; | |
| 356 | - paddingBuffer[PADDING_BUF_RETURN_VALUE] = | ||
| 357 | - Math.min(maxFramePayloadLen, | ||
| 358 | - Math.max(frameLen, | ||
| 359 | - fn(frameLen, | ||
| 360 | - maxFramePayloadLen) | 0)); | ||
| 356 | + paddingBuffer[PADDING_BUF_RETURN_VALUE] = fn(frameLen, maxFramePayloadLen); | ||
| 361 | 357 | }; | |
| 362 | 358 | } | |
| 363 | 359 | ||
0 commit comments