buffer: give names to `Buffer.prototype.*Write()` functions · nodejs/node@a1b078b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a1b078b

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

targos

committed

buffer: give names to Buffer.prototype.*Write() functions

PR-URL: #58258 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

1 parent d8e88f2 commit a1b078b
Copy full SHA for a1b078b

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • buffer.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/buffer.js‎

Copy file name to clipboardExpand all lines: lib/internal/buffer.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1043,7 +1043,7 @@ function addBufferPrototypeMethods(proto) {
1043	1043	proto.hexSlice = hexSlice;
1044	1044	proto.ucs2Slice = ucs2Slice;
1045	1045	proto.utf8Slice = utf8Slice;
1046		- proto.asciiWrite = function(string, offset = 0, length = this.byteLength - offset) {
	1046	+ proto.asciiWrite = function asciiWrite(string, offset = 0, length = this.byteLength - offset) {
1047	1047	if (offset < 0 || offset > this.byteLength) {
1048	1048	throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
1049	1049	}
@@ -1054,7 +1054,7 @@ function addBufferPrototypeMethods(proto) {
1054	1054	};
1055	1055	proto.base64Write = base64Write;
1056	1056	proto.base64urlWrite = base64urlWrite;
1057		- proto.latin1Write = function(string, offset = 0, length = this.byteLength - offset) {
	1057	+ proto.latin1Write = function latin1Write(string, offset = 0, length = this.byteLength - offset) {
1058	1058	if (offset < 0 || offset > this.byteLength) {
1059	1059	throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
1060	1060	}
@@ -1065,7 +1065,7 @@ function addBufferPrototypeMethods(proto) {
1065	1065	};
1066	1066	proto.hexWrite = hexWrite;
1067	1067	proto.ucs2Write = ucs2Write;
1068		- proto.utf8Write = function(string, offset = 0, length = this.byteLength - offset) {
	1068	+ proto.utf8Write = function utf8Write(string, offset = 0, length = this.byteLength - offset) {
1069	1069	if (offset < 0 || offset > this.byteLength) {
1070	1070	throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
1071	1071	}

0 commit comments

Comments

0 (0)