build: pass a tuple of alternatives to str.endswith() · nodejs/node@a1bee94 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a1bee94

Browse filesBrowse the repository at this point in the historyBrowse files

cclauss

authored and

targos

committed

build: pass a tuple of alternatives to str.endswith()

https://docs.python.org/3/library/stdtypes.html#str.endswith One function call should be faster than three function calls per file. PR-URL: #40017 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent d36127d commit a1bee94
Copy full SHA for a1bee94

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• configure.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1512,7 +1512,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir):
1512	1512	for ent in files:
1513	1513	(path, dirs, files) = ent
1514	1514	for file in files:
1515		- if file.endswith('.cpp') or file.endswith('.c') or file.endswith('.h'):
	1515	+ if file.endswith(('.cpp', '.c', '.h')):
1516	1516	# srcfile uses "slash" as dir separator as its output is consumed by gyp
1517	1517	srcfile = '%s/%s' % (dir_sub, file)
1518	1518	if patch_dir:

0 commit comments

Comments

0 (0)