Commit a253704
committed
process: make this value consistent
The value of `this` for callbacks of `nextTick()` can vary depending on
the number of arguments. Make it consistent.
PR-URL: #14645
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent 0d3ef5b commit a253704
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -141,7 +141,7 @@ function setupNextTick() { | |||
| 141 | 141 | callback(args[0], args[1], args[2]); | |
| 142 | 142 | break; | |
| 143 | 143 | default: | |
| 144 | - callback.apply(null, args); | ||
| 144 | + callback(...args); | ||
| 145 | 145 | } | |
| 146 | 146 | } | |
| 147 | 147 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -51,7 +51,7 @@ process.nextTick((a, b) => { | |||
| 51 | 51 | }, 42, obj); | |
| 52 | 52 | ||
| 53 | 53 | process.nextTick(function() { | |
| 54 | - assert.strictEqual(this, null); | ||
| 54 | + assert.strictEqual(this, undefined); | ||
| 55 | 55 | }, 1, 2, 3, 4); | |
| 56 | 56 | ||
| 57 | 57 | process.nextTick(() => { | |
0 commit comments