test: print instruction for creating missing snapshot in assertSnapshot · nodejs/node@a2ca1a6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a2ca1a6

Browse filesBrowse the repository at this point in the historyBrowse files

rluvaton

authored and

targos

committed

test: print instruction for creating missing snapshot in assertSnapshot

PR-URL: #48914 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 7778e19 commit a2ca1a6
Copy full SHA for a2ca1a6

1 file changed

+11-1Lines changed: 11 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/common
  • assertSnapshot.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/assertSnapshot.js‎

Copy file name to clipboardExpand all lines: test/common/assertSnapshot.js

+11-1Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -42,7 +42,17 @@ async function assertSnapshot(actual, filename = process.argv[1]) {
42	42	if (process.env.NODE_REGENERATE_SNAPSHOTS) {
43	43	await fs.writeFile(snapshot, actual);
44	44	} else {
45		- const expected = await fs.readFile(snapshot, 'utf8');
	45	+ let expected;
	46	+ try {
	47	+ expected = await fs.readFile(snapshot, 'utf8');
	48	+ } catch (e) {
	49	+ if (e.code === 'ENOENT') {
	50	+ console.log(
	51	+ 'Snapshot file does not exist. You can create a new one by running the test with NODE_REGENERATE_SNAPSHOTS=1',
	52	+ );
	53	+ }
	54	+ throw e;
	55	+ }
46	56	assert.strictEqual(actual, replaceWindowsLineEndings(expected));
47	57	}
48	58	}

0 commit comments

Comments

0 (0)