Commit a2d3f89
async_hooks: use validateBoolean for trackPromises
The `trackPromises` check duplicated `validateBoolean()` exactly: same
error code, same expected type string, same argument order. Replace it
with the validator, matching how this file already validates `type` and
`fn` via `validateString()`/`validateFunction()`.
`ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the
import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the
thrown error is unchanged from a caller's perspective.
Signed-off-by: Soul Lee <alus20x@gmail.com>
PR-URL: #64731
Refs: #61415
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>1 parent 19b9c14 commit a2d3f89
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,13 +18,13 @@ const { | |||
| 18 | 18 | ERR_ASYNC_CALLBACK, | |
| 19 | 19 | ERR_ASYNC_TYPE, | |
| 20 | 20 | ERR_INVALID_ASYNC_ID, | |
| 21 | - ERR_INVALID_ARG_TYPE, | ||
| 22 | 21 | ERR_INVALID_ARG_VALUE, | |
| 23 | 22 | } = require('internal/errors').codes; | |
| 24 | 23 | const { | |
| 25 | 24 | kEmptyObject, | |
| 26 | 25 | } = require('internal/util'); | |
| 27 | 26 | const { | |
| 27 | + validateBoolean, | ||
| 28 | 28 | validateFunction, | |
| 29 | 29 | validateString, | |
| 30 | 30 | } = require('internal/validators'); | |
@@ -84,8 +84,8 @@ class AsyncHook { | |||
| 84 | 84 | throw new ERR_ASYNC_CALLBACK('hook.destroy'); | |
| 85 | 85 | if (promiseResolve !== undefined && typeof promiseResolve !== 'function') | |
| 86 | 86 | throw new ERR_ASYNC_CALLBACK('hook.promiseResolve'); | |
| 87 | - if (trackPromises !== undefined && typeof trackPromises !== 'boolean') { | ||
| 88 | - throw new ERR_INVALID_ARG_TYPE('trackPromises', 'boolean', trackPromises); | ||
| 87 | + if (trackPromises !== undefined) { | ||
| 88 | + validateBoolean(trackPromises, 'trackPromises'); | ||
| 89 | 89 | } | |
| 90 | 90 | ||
| 91 | 91 | this[init_symbol] = init; | |
0 commit comments