Commit a383aee
benchmark: add trailing commas in benchmark/url
PR-URL: #46551
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent a10c355 commit a383aee
15 files changed
Lines changed: 28 additions & 29 deletions
File tree
- benchmark
- url
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,7 +12,6 @@ overrides: | |||
| 12 | 12 | - crypto/*.js | |
| 13 | 13 | - http/*.js | |
| 14 | 14 | - path/*.js | |
| 15 | - - url/*.js | ||
| 16 | 15 | rules: | |
| 17 | 16 | comma-dangle: [error, { | |
| 18 | 17 | arrays: always-multiline, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,7 @@ const assert = require('assert'); | |||
| 7 | 7 | const bench = common.createBenchmark(main, { | |
| 8 | 8 | type: common.urlDataTypes, | |
| 9 | 9 | method: ['legacy', 'whatwg'], | |
| 10 | - e: [1] | ||
| 10 | + e: [1], | ||
| 11 | 11 | }); | |
| 12 | 12 | ||
| 13 | 13 | function useLegacy(data) { | |
@@ -20,7 +20,7 @@ function useLegacy(data) { | |||
| 20 | 20 | port: obj.port, | |
| 21 | 21 | pathname: obj.pathname, | |
| 22 | 22 | search: obj.search, | |
| 23 | - hash: obj.hash | ||
| 23 | + hash: obj.hash, | ||
| 24 | 24 | }; | |
| 25 | 25 | const len = data.length; | |
| 26 | 26 | // It's necessary to assign the values to an object | |
@@ -51,7 +51,7 @@ function useWHATWG(data) { | |||
| 51 | 51 | port: obj.port, | |
| 52 | 52 | pathname: obj.pathname, | |
| 53 | 53 | search: obj.search, | |
| 54 | - hash: obj.hash | ||
| 54 | + hash: obj.hash, | ||
| 55 | 55 | }; | |
| 56 | 56 | const len = data.length; | |
| 57 | 57 | bench.start(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,7 +8,7 @@ const bench = common.createBenchmark(main, { | |||
| 8 | 8 | withBase: ['true', 'false'], | |
| 9 | 9 | type: common.urlDataTypes, | |
| 10 | 10 | e: [1], | |
| 11 | - method: ['legacy', 'whatwg'] | ||
| 11 | + method: ['legacy', 'whatwg'], | ||
| 12 | 12 | }); | |
| 13 | 13 | ||
| 14 | 14 | function useLegacy(data) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,7 @@ const searchParams = common.searchParams; | |||
| 6 | 6 | const bench = common.createBenchmark(main, { | |
| 7 | 7 | searchParam: Object.keys(searchParams), | |
| 8 | 8 | method: ['legacy', 'whatwg'], | |
| 9 | - n: [1e6] | ||
| 9 | + n: [1e6], | ||
| 10 | 10 | }); | |
| 11 | 11 | ||
| 12 | 12 | function useLegacy(n, input) { | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,7 @@ const searchParams = common.searchParams; | |||
| 6 | 6 | const bench = common.createBenchmark(main, { | |
| 7 | 7 | searchParam: Object.keys(searchParams), | |
| 8 | 8 | method: ['legacy', 'whatwg'], | |
| 9 | - n: [1e6] | ||
| 9 | + n: [1e6], | ||
| 10 | 10 | }); | |
| 11 | 11 | ||
| 12 | 12 | function useLegacy(n, input, prop) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,7 @@ const assert = require('assert'); | |||
| 7 | 7 | const bench = common.createBenchmark(main, { | |
| 8 | 8 | type: common.urlDataTypes, | |
| 9 | 9 | method: ['legacy', 'whatwg'], | |
| 10 | - e: [1] | ||
| 10 | + e: [1], | ||
| 11 | 11 | }); | |
| 12 | 12 | ||
| 13 | 13 | function useLegacy(data) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,7 +9,7 @@ const inputs = { | |||
| 9 | 9 | ||
| 10 | 10 | const bench = common.createBenchmark(main, { | |
| 11 | 11 | type: Object.keys(inputs), | |
| 12 | - n: [25e6] | ||
| 12 | + n: [25e6], | ||
| 13 | 13 | }); | |
| 14 | 14 | ||
| 15 | 15 | function main({ type, n }) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,12 +4,12 @@ const url = require('url'); | |||
| 4 | 4 | ||
| 5 | 5 | const inputs = { | |
| 6 | 6 | normal: 'http://foo.com/bar', | |
| 7 | - escaped: 'https://foo.bar/{}^`/abcd' | ||
| 7 | + escaped: 'https://foo.bar/{}^`/abcd', | ||
| 8 | 8 | }; | |
| 9 | 9 | ||
| 10 | 10 | const bench = common.createBenchmark(main, { | |
| 11 | 11 | type: Object.keys(inputs), | |
| 12 | - n: [1e7] | ||
| 12 | + n: [1e7], | ||
| 13 | 13 | }); | |
| 14 | 14 | ||
| 15 | 15 | function main({ type, n }) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,13 +9,13 @@ const paths = { | |||
| 9 | 9 | 'sibling': '../foo/bar?baz=boom', | |
| 10 | 10 | 'foo/bar': 'foo/bar', | |
| 11 | 11 | 'withscheme': 'http://nodejs.org', | |
| 12 | - 'down': './foo/bar?baz' | ||
| 12 | + 'down': './foo/bar?baz', | ||
| 13 | 13 | }; | |
| 14 | 14 | ||
| 15 | 15 | const bench = common.createBenchmark(main, { | |
| 16 | 16 | href: Object.keys(hrefs), | |
| 17 | 17 | path: Object.keys(paths), | |
| 18 | - n: [1e5] | ||
| 18 | + n: [1e5], | ||
| 19 | 19 | }); | |
| 20 | 20 | ||
| 21 | 21 | function main({ n, href, path }) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,7 +4,7 @@ const assert = require('assert'); | |||
| 4 | 4 | ||
| 5 | 5 | const bench = common.createBenchmark(main, { | |
| 6 | 6 | loopMethod: ['forEach', 'iterator'], | |
| 7 | - n: [1e6] | ||
| 7 | + n: [1e6], | ||
| 8 | 8 | }); | |
| 9 | 9 | ||
| 10 | 10 | const str = 'one=single&two=first&three=first&two=2nd&three=2nd&three=3rd'; | |
0 commit comments