http2: refactor to use primordials instead of <string>.indexOf · nodejs/node@a38ad07 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a38ad07

Browse filesBrowse the repository at this point in the historyBrowse files

rchougule

authored and

danielleadams

committed

http2: refactor to use primordials instead of <string>.indexOf

PR-URL: #36679 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 7c7180a commit a38ad07
Copy full SHA for a38ad07

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/http2
  • compat.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/http2/compat.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/compat.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -11,6 +11,7 @@ const {
11	11	ObjectPrototypeHasOwnProperty,
12	12	ReflectApply,
13	13	ReflectGetPrototypeOf,
	14	+ StringPrototypeIncludes,
14	15	StringPrototypeToLowerCase,
15	16	StringPrototypeTrim,
16	17	Symbol,
@@ -81,7 +82,9 @@ let statusConnectionHeaderWarned = false;
81	82	// close as possible to the current require('http') API
82	83
83	84	const assertValidHeader = hideStackFrames((name, value) => {
84		- if (name === '' || typeof name !== 'string' || name.indexOf(' ') >= 0) {
	85	+ if (name === '' ||
	86	+ typeof name !== 'string' ||
	87	+ StringPrototypeIncludes(name, ' ')) {
85	88	throw new ERR_INVALID_HTTP_TOKEN('Header name', name);
86	89	}
87	90	if (isPseudoHeader(name)) {

0 commit comments

Comments

0 (0)