Commit a3b758d
test: move test-https-server-consumed-timeout to parallel
Change the test to be robust in slow environments and move to parallel.
The previous version of the test failed for me in parallel with just two
or four simultaneous versions running. This version passes 96
simultaneous versions running, but still fails as designed if the
request writes fail to prevent the request timeout from occurring.
PR-URL: #30677
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 00f532f commit a3b758d
2 files changed
Lines changed: 86 additions & 52 deletions
File tree
- test
- parallel
- sequential
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,86 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + | ||
| 3 | + const common = require('../common'); | ||
| 4 | + | ||
| 5 | + const assert = require('assert'); | ||
| 6 | + const http = require('http'); | ||
| 7 | + | ||
| 8 | + const durationBetweenIntervals = []; | ||
| 9 | + let timeoutTooShort = false; | ||
| 10 | + const TIMEOUT = common.platformTimeout(200); | ||
| 11 | + const INTERVAL = Math.floor(TIMEOUT / 8); | ||
| 12 | + | ||
| 13 | + runTest(TIMEOUT); | ||
| 14 | + | ||
| 15 | + function runTest(timeoutDuration) { | ||
| 16 | + let intervalWasInvoked = false; | ||
| 17 | + let newTimeoutDuration = 0; | ||
| 18 | + const closeCallback = (err) => { | ||
| 19 | + assert.ifError(err); | ||
| 20 | + if (newTimeoutDuration) { | ||
| 21 | + runTest(newTimeoutDuration); | ||
| 22 | + } | ||
| 23 | + }; | ||
| 24 | + | ||
| 25 | + const server = http.createServer((req, res) => { | ||
| 26 | + server.close(common.mustCall(closeCallback)); | ||
| 27 | + | ||
| 28 | + res.writeHead(200); | ||
| 29 | + res.flushHeaders(); | ||
| 30 | + | ||
| 31 | + req.setTimeout(timeoutDuration, () => { | ||
| 32 | + if (!intervalWasInvoked) { | ||
| 33 | + // Interval wasn't invoked, probably because the machine is busy with | ||
| 34 | + // other things. Try again with a longer timeout. | ||
| 35 | + newTimeoutDuration = timeoutDuration * 2; | ||
| 36 | + console.error('The interval was not invoked.'); | ||
| 37 | + console.error(`Trying w/ timeout of ${newTimeoutDuration}.`); | ||
| 38 | + return; | ||
| 39 | + } | ||
| 40 | + | ||
| 41 | + if (timeoutTooShort) { | ||
| 42 | + intervalWasInvoked = false; | ||
| 43 | + timeoutTooShort = false; | ||
| 44 | + newTimeoutDuration = | ||
| 45 | + Math.max(...durationBetweenIntervals, timeoutDuration) * 2; | ||
| 46 | + console.error(`Time between intervals: ${durationBetweenIntervals}`); | ||
| 47 | + console.error(`Trying w/ timeout of ${newTimeoutDuration}`); | ||
| 48 | + return; | ||
| 49 | + } | ||
| 50 | + | ||
| 51 | + assert.fail('Request timeout should not fire'); | ||
| 52 | + }); | ||
| 53 | + | ||
| 54 | + req.resume(); | ||
| 55 | + req.once('end', () => { | ||
| 56 | + res.end(); | ||
| 57 | + }); | ||
| 58 | + }); | ||
| 59 | + | ||
| 60 | + server.listen(0, common.mustCall(() => { | ||
| 61 | + const req = http.request({ | ||
| 62 | + port: server.address().port, | ||
| 63 | + method: 'POST' | ||
| 64 | + }, () => { | ||
| 65 | + let lastIntervalTimestamp = Date.now(); | ||
| 66 | + const interval = setInterval(() => { | ||
| 67 | + const lastDuration = Date.now() - lastIntervalTimestamp; | ||
| 68 | + durationBetweenIntervals.push(lastDuration); | ||
| 69 | + lastIntervalTimestamp = Date.now(); | ||
| 70 | + if (lastDuration > timeoutDuration / 2) { | ||
| 71 | + // The interval is supposed to be about 1/8 of the timeout duration. | ||
| 72 | + // If it's running so infrequently that it's greater than 1/2 the | ||
| 73 | + // timeout duration, then run the test again with a longer timeout. | ||
| 74 | + timeoutTooShort = true; | ||
| 75 | + } | ||
| 76 | + intervalWasInvoked = true; | ||
| 77 | + req.write('a'); | ||
| 78 | + }, INTERVAL); | ||
| 79 | + setTimeout(() => { | ||
| 80 | + clearInterval(interval); | ||
| 81 | + req.end(); | ||
| 82 | + }, timeoutDuration); | ||
| 83 | + }); | ||
| 84 | + req.write('.'); | ||
| 85 | + })); | ||
| 86 | + } | ||
This file was deleted.
0 commit comments