Commit a3b7e59
http2: use Object.create(null) for getHeaders
refactor `getHeaders` to initialize headers using
`Object.create(null)`
Refs: #29829
PR-URL: #33188
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent ed741ec commit a3b7e59
2 files changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -555,7 +555,8 @@ class Http2ServerResponse extends Stream { | |||
| 555 | 555 | } | |
| 556 | 556 | ||
| 557 | 557 | getHeaders() { | |
| 558 | - return { ...this[kHeaders] }; | ||
| 558 | + const headers = ObjectCreate(null); | ||
| 559 | + return ObjectAssign(headers, this[kHeaders]); | ||
| 559 | 560 | } | |
| 560 | 561 | ||
| 561 | 562 | hasHeader(name) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -102,11 +102,13 @@ server.listen(0, common.mustCall(function() { | |||
| 102 | 102 | response.setHeader(real, expectedValue); | |
| 103 | 103 | const expectedHeaderNames = [real]; | |
| 104 | 104 | assert.deepStrictEqual(response.getHeaderNames(), expectedHeaderNames); | |
| 105 | - const expectedHeaders = { [real]: expectedValue }; | ||
| 105 | + const expectedHeaders = Object.create(null); | ||
| 106 | + expectedHeaders[real] = expectedValue; | ||
| 106 | 107 | assert.deepStrictEqual(response.getHeaders(), expectedHeaders); | |
| 107 | 108 | ||
| 108 | 109 | response.getHeaders()[fake] = fake; | |
| 109 | 110 | assert.strictEqual(response.hasHeader(fake), false); | |
| 111 | + assert.strictEqual(Object.getPrototypeOf(response.getHeaders()), null); | ||
| 110 | 112 | ||
| 111 | 113 | assert.strictEqual(response.sendDate, true); | |
| 112 | 114 | response.sendDate = false; | |
0 commit comments