src: use C++14 deprecated attribute for `NODE_DEPRECATED` · nodejs/node@a408f27 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a408f27

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

aduh95

committed

src: use C++14 deprecated attribute for NODE_DEPRECATED

This has been standardized for a while, so there's no real reason not to just use it over compiler-specific alternatives. Signed-off-by: Anna Henningsen <anna@addaleax.net> PR-URL: #63755 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent e3e5ef1 commit a408f27
Copy full SHA for a408f27

1 file changed

+1-9Lines changed: 1 addition & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node.h‎

Copy file name to clipboardExpand all lines: src/node.h

+1-9Lines changed: 1 addition & 9 deletions

Original file line number	Diff line number	Diff line change
@@ -111,15 +111,7 @@
111	111	#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
112	112	# define NODE_DEPRECATED(message, declarator) declarator
113	113	#else // NODE_WANT_INTERNALS
114		- # if NODE_CLANG_AT_LEAST(2, 9, 0) || NODE_GNUC_AT_LEAST(4, 5, 0)
115		- # define NODE_DEPRECATED(message, declarator) \
116		- __attribute__((deprecated(message))) declarator
117		- # elif defined(_MSC_VER)
118		- # define NODE_DEPRECATED(message, declarator) \
119		- __declspec(deprecated) declarator
120		- # else
121		- # define NODE_DEPRECATED(message, declarator) declarator
122		- # endif
	114	+ #define NODE_DEPRECATED(message, declarator) [[deprecated(message)]] declarator
123	115	#endif
124	116
125	117	// Forward-declare libuv loop

0 commit comments

Comments

0 (0)