Commit a4557f2
build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: #16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent 41937be commit a4557f2
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -315,6 +315,11 @@ | |||
| 315 | 315 | 'NODE_OPENSSL_SYSTEM_CERT_PATH="<(openssl_system_ca_path)"', | |
| 316 | 316 | ], | |
| 317 | 317 | }, | |
| 318 | + 'conditions': [ | ||
| 319 | + [ 'node_shared=="true" and node_module_version!="" and OS!="win"', { | ||
| 320 | + 'product_extension': '<(shlib_suffix)', | ||
| 321 | + }] | ||
| 322 | + ], | ||
| 318 | 323 | }, | |
| 319 | 324 | { | |
| 320 | 325 | 'target_name': 'mkssldef', | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,11 +11,6 @@ | |||
| 11 | 11 | 'defines': [ | |
| 12 | 12 | 'NODE_SHARED_MODE', | |
| 13 | 13 | ], | |
| 14 | - 'conditions': [ | ||
| 15 | - [ 'node_module_version!="" and OS!="win"', { | ||
| 16 | - 'product_extension': '<(shlib_suffix)', | ||
| 17 | - }] | ||
| 18 | - ], | ||
| 19 | 14 | }], | |
| 20 | 15 | [ 'node_enable_d8=="true"', { | |
| 21 | 16 | 'dependencies': [ 'deps/v8/src/d8.gyp:d8' ], | |
0 commit comments