test: fix `test-repl` not validating leaked globals properly · nodejs/node@a46dd37 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a46dd37

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

juanarbol

committed

test: fix test-repl not validating leaked globals properly

PR-URL: #44640 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

1 parent 24172ca commit a46dd37
Copy full SHA for a46dd37

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-repl.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-repl.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-repl.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -835,7 +835,8 @@ const tcpTests = [
835	835
836	836	socket.end();
837	837	}
838		- common.allowGlobals(...Object.values(global));
	838	+ common.allowGlobals(global.invoke_me, global.message, global.a, global.blah,
	839	+ global.I, global.f, global.path, global.x, global.name, global.foo);
839	840	})().then(common.mustCall());
840	841
841	842	function startTCPRepl() {

0 commit comments

Comments

0 (0)